Skip to content

fix(node-utils): unit test on node24#23217

Merged
Lemonexe merged 1 commit intodevelopfrom
fix/node24-unit-test
Nov 18, 2025
Merged

fix(node-utils): unit test on node24#23217
Lemonexe merged 1 commit intodevelopfrom
fix/node24-unit-test

Conversation

@Lemonexe
Copy link
Copy Markdown
Contributor

@Lemonexe Lemonexe commented Nov 18, 2025

Description

Fix unit tests that started failing after #23206
because sadly the unit test did not run.

Notes

I created a minimal file for testing this in node 22 vs node 24, and confirmed that even outside of trezor-suite:

  • Linux node22 'node'
  • Linux node24 'MainThread'
  • Windows is the same: 'Node.js'

🔍🖥️ Suite web test results: View in Currents

🔍🖥️ Suite desktop test results: View in Currents

@Lemonexe Lemonexe added the no-project This label is used to specify that PR doesn't need to be added to a project label Nov 18, 2025
@Lemonexe Lemonexe marked this pull request as ready for review November 18, 2025 15:23
@Lemonexe Lemonexe requested a review from karliatto as a code owner November 18, 2025 15:23
@Lemonexe Lemonexe enabled auto-merge (rebase) November 18, 2025 15:46
@Lemonexe Lemonexe merged commit 78435bc into develop Nov 18, 2025
50 of 52 checks passed
@Lemonexe Lemonexe deleted the fix/node24-unit-test branch November 18, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-project This label is used to specify that PR doesn't need to be added to a project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants