Skip to content

chore: use node 24#23206

Merged
Lemonexe merged 1 commit intodevelopfrom
node24
Nov 18, 2025
Merged

chore: use node 24#23206
Lemonexe merged 1 commit intodevelopfrom
node24

Conversation

@Lemonexe
Copy link
Copy Markdown
Contributor

@Lemonexe Lemonexe commented Nov 17, 2025

Description

Bump nodeJS from 22 to 24, as it was released as LTS a week ago 🚀

Devs, please try nvm i && yarn and check that your local dev environment works.

QA Notes

I made sure to trigger all kinds of CI in 7206888 (and I checked it does use node 24, not node 22)

Besides CI, I made sure that this stuff works:

  • local dev web ✔️
  • local dev desktop ✔️
  • local dev metro with android emu
  • building node-bridge and using it ✔️
  • sldev web ✔️
    • note that only build is affected
  • CI desktop builds .AppImage and .exe ✔️
    • note that only build is affected, while runtime is controlled by Electron, resp. Chromium, and is still 22
  • local storybook ✔️

Related Issue

Resolve #23207

🔍🖥️ Suite web test results: View in Currents

🔍🖥️ Suite desktop test results: View in Currents

🔍🖥️ Suite native android test results: View in Currents

@Lemonexe Lemonexe added no-project This label is used to specify that PR doesn't need to be added to a project and removed no-project This label is used to specify that PR doesn't need to be added to a project labels Nov 17, 2025
@trezor-bot
Copy link
Copy Markdown
Contributor

trezor-bot Bot commented Nov 17, 2025

✅ Previously successful run of [Test] PR Suite Desktop e2e tests workflow has been found.
⏭️ Skipping tests for this run.
💡 If you are unsure about your latest changes, please rerun the workflow manually. (Use the Re-run all jobs option)

@trezor-bot
Copy link
Copy Markdown
Contributor

trezor-bot Bot commented Nov 17, 2025

✅ Previously successful run of [Test] PR Suite Web e2e tests workflow has been found.
⏭️ Skipping tests for this run.
💡 If you are unsure about your latest changes, please rerun the workflow manually. (Use the Re-run all jobs option)

@Lemonexe Lemonexe marked this pull request as ready for review November 17, 2025 21:39
Copy link
Copy Markdown
Contributor

@peter-sanderson peter-sanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me :)

Copy link
Copy Markdown
Contributor

@OriginalEveres OriginalEveres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested on Mac and it works. I just needed to clean nx cache.

xCode emulator also works, tested with iOS 26.1 and works.

@Lemonexe Lemonexe merged commit 1e18758 into develop Nov 18, 2025
25 checks passed
@Lemonexe Lemonexe deleted the node24 branch November 18, 2025 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bump node to 24

4 participants