Skip to content

chore(scripts): reassign some dependencies#22886

Merged
komret merged 1 commit intodevelopfrom
chore/rearrange-foundation-dependencies
Nov 18, 2025
Merged

chore(scripts): reassign some dependencies#22886
komret merged 1 commit intodevelopfrom
chore/rearrange-foundation-dependencies

Conversation

@Lemonexe
Copy link
Copy Markdown
Contributor

@Lemonexe Lemonexe commented Nov 4, 2025

Description

Suggestion to slightly reorganize a few dependencies after #22747:

  • all webpack related → foundation
  • simple-git → growth (it's only used for Suite Guide)
  • golomb, n64 = libs related to that cursed feature which shall not be named → wallet team (it's bitcoin)

🔍🖥️ Suite web test results: View in Currents

🔍🖥️ Suite desktop test results: View in Currents

@Lemonexe Lemonexe marked this pull request as ready for review November 4, 2025 12:23
@Lemonexe Lemonexe requested a review from karliatto as a code owner November 4, 2025 12:23
Copy link
Copy Markdown
Member

@karliatto karliatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok 👍

@Lemonexe Lemonexe force-pushed the chore/rearrange-foundation-dependencies branch from a298cbf to a65d77c Compare November 13, 2025 14:24
@trezor-bot
Copy link
Copy Markdown
Contributor

trezor-bot Bot commented Nov 13, 2025

✅ Previously successful run of [Test] PR Suite Web e2e tests workflow has been found.
⏭️ Skipping tests for this run.
💡 If you are unsure about your latest changes, please rerun the workflow manually. (Use the Re-run all jobs option)

@Lemonexe Lemonexe force-pushed the chore/rearrange-foundation-dependencies branch 2 times, most recently from 2844e59 to 912210f Compare November 13, 2025 14:37
@Lemonexe Lemonexe force-pushed the chore/rearrange-foundation-dependencies branch from 912210f to a8ef305 Compare November 17, 2025 18:31
@trezor-bot
Copy link
Copy Markdown
Contributor

trezor-bot Bot commented Nov 17, 2025

✅ Previously successful run of [Test] PR Suite Desktop e2e tests workflow has been found.
⏭️ Skipping tests for this run.
💡 If you are unsure about your latest changes, please rerun the workflow manually. (Use the Re-run all jobs option)

@Lemonexe Lemonexe force-pushed the chore/rearrange-foundation-dependencies branch from a8ef305 to 6e9f713 Compare November 18, 2025 11:52
@komret komret enabled auto-merge (rebase) November 18, 2025 12:09
@komret komret merged commit c5b0c71 into develop Nov 18, 2025
22 checks passed
@komret komret deleted the chore/rearrange-foundation-dependencies branch November 18, 2025 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants