Conversation
komret
requested review from
HajekOndrej,
jvaclavik,
mroz22,
tomasklim and
vytick
komret
added
dependencies
| react-refresh | ||
| react-use | ||
| redux | ||
| redux-devtools-expo-dev-plugin |
| redux-devtools-expo-dev-plugin | ||
| redux-logger | ||
| redux-mock-store | ||
| react-native-quick-crypto |
There was a problem hiding this comment.
Sounds like a wallet-related dependency to me: "QuickCrypto can be used as a drop-in replacement for your Web3/Crypto apps to speed up common cryptography functions"
There was a problem hiding this comment.
I would say Foundation, it is for all crypto functions (crypto as a cryptography, not crypto as a cryptocurrencies)
There was a problem hiding this comment.
I moved most of cryptography-related dependencies to Wallet team because most of them is used in utxo-lib.
| redux-logger | ||
| redux-mock-store | ||
| react-native-quick-crypto | ||
| redux-persist |
There was a problem hiding this comment.
Closely related to redux, which already belongs to Wallet. This is used mostly on mobile, but I don't want to give all mobile deps to one team.
There was a problem hiding this comment.
related to redux, but also a dead project, don't expect any updates there 🙉 But it would potentially mean a lot of work to find some maintained replacement.
komret
force-pushed
the
chore/dependency-lists
branch
from
b6f7ca4 to
ec76450
Compare
|
✅ Previously successful run of [Test] PR Suite Web e2e tests workflow has been found. |
|
/rebase |
trezor-bot
Bot
force-pushed
the
chore/dependency-lists
branch
from
ec76450 to
55a1f5e
Compare
|
✅ Previously successful run of [Test] PR Suite Desktop e2e tests workflow has been found. |
|
lets start with this (trade) |
6 participants
My best attempt to make this fair and reasonable.
🔍🖥️ Suite web test results: View in Currents
🔍🖥️ Suite desktop test results: View in Currents