chore(ci): sanitize branch names for connect popup build

[Lemonexe]

Description

Sanitize branch names for connect popup build base URL

• otherwise it can crash with a cryptic error (example) that can be hard to debug.
• now it will strip those characters: run for invalid+#@&=branch, successfully deployed here

🔍🖥️ Suite web test results: View in Currents

🔍🖥️ Suite desktop test results: View in Currents

[trezor-bot]

✅ Previously successful run of [Test] PR Suite Web e2e tests workflow has been found.
⏭️ Skipping tests for this run.
💡 If you are unsure about your latest changes, please rerun the workflow manually. (Use the Re-run all jobs option)

[trezor-bot]

✅ Previously successful run of [Test] PR Suite Desktop e2e tests workflow has been found.
⏭️ Skipping tests for this run.
💡 If you are unsure about your latest changes, please rerun the workflow manually. (Use the Re-run all jobs option)

[Lemonexe]

technically, chars ?\:* do not need to be handled because that's an invalid branch name (git won't allow to create it), but I put it there anyway so it's clearer what kind of bugs does this solve

[vdovhanych]

did we hit this issue somewhere already?

[Lemonexe]

did we hit this issue somewhere already?

@vdovhanych yes, in the PR of the action run that I linked above I did that and was wondering why connect won't build.

I looked at all branches at origin and seems that it is not a common mistake, so maybe I'm just weird 😆
Still, when someone does create such a branch name, the issue is difficult to debug, so this might save time for someone in future.

[Lemonexe]

/rebase

[github-actions]

Start rebasing: https://github.com/trezor/trezor-suite/actions/runs/14875791010

[trezor-bot]

✅ Previously successful run of [Test] PR Suite Desktop e2e tests workflow has been found.
⏭️ Skipping tests for this run.
💡 If you are unsure about your latest changes, please rerun the workflow manually. (Use the Re-run all jobs option)

[trezor-bot]

✅ Previously successful run of [Test] PR Suite Web e2e tests workflow has been found.
⏭️ Skipping tests for this run.
💡 If you are unsure about your latest changes, please rerun the workflow manually. (Use the Re-run all jobs option)

[martykan]

In your example run, the deployment works but all of the tests fail. You also need to escape it in template-connect-popup-test-params.yml

[vdovhanych]

Interesting. I would never even consider using those symbols for branch names, but yeah, if you think it's worth fixing, let's do it. I would just do it for everything, not just connect.

[Lemonexe]

Ok @vdovhanych I am closing it.
I wanted to play a little with github actions, but

• noone has this problem
  • me randomly creating a weird branch name once in a lifetime is not a reason to add more complexity 😄
• there is much more work needed as many tests are still failing