fix(suite-desktop-core): remove obsolete option from notarize call#17079
Merged
fix(suite-desktop-core): remove obsolete option from notarize call#17079
Conversation
Lemonexe
added
the
no-project
peter-sanderson
approved these changes
Feb 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Followup to #17056, where TS was turned on, and gave error at
@electron/notarizeinterface.I am sure that
appBundleIdoption is useless ✔️Based on
tooloption there are two interfaces: new & legacy.We're on v2.5.0 so I looked at the repo at that commit.
'legacy'is actually not implemented, it just throws error (see link above)appBundleIdis not mentioned anywhere in code but the legacy type declarationFYI docs for the new interface
@coderabbitai ignore