feat(connect-popup): call method via URL params #14044
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martykan
force-pushed
the
feat/connect-popup-via-url-params
branch
from
8a3b5c8 to
a106f75
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| console.log('response', event.data); | ||
| const callback = urlParams.get('callback'); | ||
| if (callback) { | ||
| location.href = `${callback}?response=${encodeURIComponent(JSON.stringify(event.data.payload))}`; |
Check warning
Code scanning / CodeQL
Client-side URL redirect Medium
| console.log('response', event.data); | ||
| const callback = urlParams.get('callback'); | ||
| if (callback) { | ||
| location.href = `${callback}?response=${encodeURIComponent(JSON.stringify(event.data.payload))}`; |
Check failure
Code scanning / CodeQL
Client-side cross-site scripting High
Closed
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This idea came from discussion about using deep links for Connect on mobile.
If we have a HTTPS URL for Connect, which is handled by deep linking into the app, it's a good idea to some fallback content if the user doesn't have the app installed and opens it in a browser.
So I prepared a POC to support this same deep linking flow with Connect Popup, that could be used for desktop.
With this change popup.html now supports the following URL parameters:
For example:
https://dev.suite.sldev.cz/connect/feat/connect-popup-via-url-params/popup.html?method=getAddress¶ms=%7B%22path%22:%22m/49%27/0%27/0%27/0/0%22%7D&callback=https://httpbin.org/get