Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[epic] connect - mobile support - phase 1 #14248

Closed
5 of 8 tasks
mroz22 opened this issue Sep 10, 2024 · 1 comment
Closed
5 of 8 tasks

[epic] connect - mobile support - phase 1 #14248

mroz22 opened this issue Sep 10, 2024 · 1 comment
Labels
connect Connect API related (ie. fee calculation) connect-react-native

Comments

@mroz22
Copy link
Contributor

mroz22 commented Sep 10, 2024

Goal: give the 3rd parties the ability to talk to Trezor devices easily.

Suite-lite as connect provider #13648

  • @Nodonisko creates a PR with very basic barebones of the project so that we know where we put our code.
  • trezor-suite-lite is capable of handling deep links, which are connect API calls. It hands over such a call to its internal instance of connect and returns the response via a callback URL provided in the link.
  • some basic UI within trezor-suite-lite
  • there should be a thin package exposing trezor-connect API with deeplinks as the underlying communication mechanism
  • example of a client application for demonstration purposes.

followups

UI-less SDK #13647

we are not sure if want to do it - it would bundle all the expo modules which is probably too heavyweight for 3rd parties to implement. @Nodonisko has some ideas how it could be solved but it is still in the making

  • self-contained within the monorepo structure - I should be able to import and use it. If there is any platform-specific work, it should be documented in a readme file.
  • suite-lite is using this SDK
  • we can run @trezor/connect e2e tests in react-native environment
  • consider expo vs non-expo?
  • consider connect - core - option to force all inputs on device #13646
  • consider releasing it as an npm package and mentioning it in the public documentation.

deeplinks vs applinks

related issues

team

@mroz22 mroz22 added the connect Connect API related (ie. fee calculation) label Sep 10, 2024
@github-project-automation github-project-automation bot moved this to 🎯 To do in Suite Desktop Sep 10, 2024
@mroz22 mroz22 changed the title [epic] connect - mobile support - phase 2 [epic] connect - mobile support - phase 1 Sep 10, 2024
@Hannsek
Copy link
Contributor

Hannsek commented Oct 18, 2024

Let's close this for now, ok?

@Hannsek Hannsek closed this as not planned Won't fix, can't repro, duplicate, stale Oct 18, 2024
@github-project-automation github-project-automation bot moved this from 🎯 To do to 🤝 Needs QA in Suite Desktop Oct 18, 2024
@evgenysl evgenysl removed the status in Suite Desktop Oct 22, 2024
@evgenysl evgenysl moved this to 🤝 Needs QA in Suite Desktop Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
connect Connect API related (ie. fee calculation) connect-react-native
Projects
Archived in project
Development

No branches or pull requests

2 participants