Connect/dispose core in popup #12198
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mroz22
commented
Apr 29, 2024
•
mroz22
commented
- while doing fix(connect): fix device release and cancel on beforeunload #12170 I realize that we don't dispose core when loaded into popup. Without it, users could bump into some wrong previous session problems. Also dialogues on device wouldn't be correctly canceled. This could be contributing to webextension tests flakiness.
- I am not sure if it is worth merging now because of trezord-go dies after post cancel #12210
mroz22
force-pushed
the
connect/dispose-core-in-popup
branch
from
646701a to
b18bdf5
Compare
mroz22
requested review from
szymonlesisz,
martykan and
vdovhanych
as code owners
martykan
reviewed
Apr 29, 2024
mroz22
force-pushed
the
connect/dispose-core-in-popup
branch
from
e3671dd to
888aa15
Compare
vdovhanych
approved these changes
Apr 30, 2024
mroz22
force-pushed
the
connect/dispose-core-in-popup
branch
2 times, most recently
from
a538699 to
3233bec
Compare
mroz22
force-pushed
the
connect/dispose-core-in-popup
branch
from
3233bec to
309430a
Compare
mroz22
force-pushed
the
connect/dispose-core-in-popup
branch
from
309430a to
c4581ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.