fix(connect): fix device release and cancel on beforeunload #12170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroz22
force-pushed
the
connect/release-on-reload
branch
2 times, most recently
from
3ef0486 to
f10f5e1
Compare
szymonlesisz
approved these changes
Apr 29, 2024
There was a problem hiding this comment.
TrezorConnect.dispose is no longer then-able. Is that a big deal?
shouldnt break anything, it becomes an async method not so long ago
|
/rebase |
trezor-ci
force-pushed
the
connect/release-on-reload
branch
from
f10f5e1 to
876d3d9
Compare
This was referenced Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
while testing #11532 I finally fixed a long-lasting issue (see screenshots).
when you reload while on this screen:
you should not end up on this screen
breaking change
TrezorConnect.dispose is no longer then-able. Is that a big deal?