Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure dependant tasks fail properly via https://github.com/orgs/community/discussions/26822 #2589

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

Licenser
Copy link
Member

@Licenser Licenser commented Jun 17, 2024

Pull request

Description

CI has let dependabot merge non working changes, this is due to github not failing dependant actions and instead marking them as skipped - this leads to them seen as passed.

Checklist

  • The RFC, if required, has been submitted and approved
  • Any user-facing impact of the changes is reflected in docs.tremor.rs
  • The code is tested
  • Use of unsafe code is reasoned about in a comment
  • Update CHANGELOG.md appropriately, recording any changes, bug fixes, or other observable changes in behavior
  • The performance impact of the change is measured (see below)

Performance

-/-

Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.35%. Comparing base (453cc07) to head (559b763).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2589      +/-   ##
==========================================
+ Coverage   91.33%   91.35%   +0.01%     
==========================================
  Files         308      308              
  Lines       60109    60109              
==========================================
+ Hits        54902    54914      +12     
+ Misses       5207     5195      -12     
Flag Coverage Δ
e2e-command 11.23% <ø> (ø)
e2e-integration 51.86% <ø> (+0.18%) ⬆️
e2e-unit 12.45% <ø> (ø)
e2etests 54.18% <ø> (+0.18%) ⬆️
tremorapi 14.34% <ø> (ø)
tremorcodec 62.94% <ø> (ø)
tremorcommon 63.15% <ø> (ø)
tremorconnectors 28.60% <ø> (ø)
tremorconnectorsaws 11.48% <ø> (ø)
tremorconnectorsazure 5.03% <ø> (ø)
tremorconnectorsgcp 21.28% <ø> (ø)
tremorconnectorsobjectstorage 0.00% <ø> (ø)
tremorconnectorsotel 12.67% <ø> (ø)
tremorconnectorstesthelpers 60.56% <ø> (ø)
tremorinflux 87.72% <ø> (ø)
tremorinterceptor 53.73% <ø> (ø)
tremorpipeline 31.06% <ø> (ø)
tremorruntime 46.64% <ø> (+<0.01%) ⬆️
tremorscript 54.26% <ø> (ø)
tremorsystem 5.75% <ø> (ø)
tremorvalue 70.24% <ø> (ø)
unittests 88.32% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 453cc07...559b763. Read the comment docs.

Copy link
Member

@darach darach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Licenser Licenser enabled auto-merge (rebase) June 18, 2024 07:59
@Licenser Licenser merged commit f8f97fb into main Jun 18, 2024
58 checks passed
@Licenser Licenser deleted the ensure-ci-failing branch June 18, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants