Ensure dependant tasks fail properly via https://github.com/orgs/comm…

…unity/discussions/26822 Signed-off-by: Heinz N. Gies <[email protected]>
tremor-rs · Jun 18, 2024 · 559b763 · 559b763
1 parent 453cc07
commit 559b763
Show file tree

Hide file tree

Showing 3 changed files with 65 additions and 26 deletions.
diff --git a/.github/workflows/checks.yaml b/.github/workflows/checks.yaml
@@ -15,7 +15,7 @@ jobs:
       - uses: actions/checkout@v4
       - uses: EmbarkStudios/cargo-deny-action@v1
         with:
-          command: check bans licenses sources 
+          command: check bans licenses sources
   license:
     runs-on: ubuntu-latest
     steps:
@@ -32,24 +32,24 @@ jobs:
     strategy:
       matrix:
         crate: [
-          ".", # tremor-runtime
-          "tremor-api",
-          "tremor-cli",
-          "tremor-codec",
-          "tremor-common",
-          "tremor-influx",
-          "tremor-interceptor",
-          "tremor-pipeline",
-          "tremor-script",
-          "tremor-value",
-          "tremor-system",
-          "tremor-connectors",
-          "tremor-connectors-aws",
-          "tremor-connectors-azure",
-          "tremor-connectors-gcp",
-          "tremor-connectors-otel",
-          "tremor-connectors-object-storage",
-          "tremor-connectors-test-helpers",
+            ".", # tremor-runtime
+            "tremor-api",
+            "tremor-cli",
+            "tremor-codec",
+            "tremor-common",
+            "tremor-influx",
+            "tremor-interceptor",
+            "tremor-pipeline",
+            "tremor-script",
+            "tremor-value",
+            "tremor-system",
+            "tremor-connectors",
+            "tremor-connectors-aws",
+            "tremor-connectors-azure",
+            "tremor-connectors-gcp",
+            "tremor-connectors-otel",
+            "tremor-connectors-object-storage",
+            "tremor-connectors-test-helpers",
           ]
     runs-on: ubuntu-latest
     steps:
@@ -93,8 +93,16 @@ jobs:
         run: cargo clippy --all
 
   code-quality:
+    if: ${{ always() }}
     name: Code Quality
     runs-on: ubuntu-latest
     needs: [format, clippy-check, unused-deps, safety, license, audit]
     steps:
-      - run: echo "All tests passed"
+      - run: exit 1
+        # see https://stackoverflow.com/a/67532120/4907315
+        if: >-
+          ${{
+               contains(needs.*.result, 'failure')
+            || contains(needs.*.result, 'cancelled')
+            || contains(needs.*.result, 'skipped')
+          }}
diff --git a/.github/workflows/integration.yaml b/.github/workflows/integration.yaml
@@ -61,8 +61,16 @@ jobs:
             verbose: true
 
   integration-tests:
+    if: ${{ always() }}
     name: Integration Tests
     runs-on: ubuntu-latest
     needs: cli-test-harness
     steps:
-      - run: echo "All tests passed"
+      - run: exit 1
+        # see https://stackoverflow.com/a/67532120/4907315
+        if: >-
+          ${{
+               contains(needs.*.result, 'failure')
+            || contains(needs.*.result, 'cancelled')
+            || contains(needs.*.result, 'skipped')
+          }}
diff --git a/.github/workflows/tests.yaml b/.github/workflows/tests.yaml
@@ -25,7 +25,7 @@ jobs:
             "tremor-system",
             "tremor-runtime",
             "tremor-connectors-object-storage",
-            "tremor-connectors-test-helpers"
+            "tremor-connectors-test-helpers",
           ]
     runs-on: ubuntu-latest-16-cores
     steps:
@@ -112,22 +112,45 @@ jobs:
             verbose: true
 
   core-tests:
+    if: ${{ always() }}
     name: Core Tests
     runs-on: ubuntu-latest
     needs: [tests-linux]
     steps:
-      - run: echo "All tests passed"
+      - run: exit 1
+        # see https://stackoverflow.com/a/67532120/4907315
+        if: >-
+          ${{
+               contains(needs.*.result, 'failure')
+            || contains(needs.*.result, 'cancelled')
+          }}
 
   connector-tests:
+    if: ${{ always() }}
     name: Connector Tests
     runs-on: ubuntu-latest
     needs: [connectors-linux]
     steps:
-      - run: echo "All tests passed"
-
+      - run: exit 1
+        # see https://stackoverflow.com/a/67532120/4907315
+        if: >-
+          ${{
+               contains(needs.*.result, 'failure')
+            || contains(needs.*.result, 'cancelled')
+            || contains(needs.*.result, 'skipped')
+          }}
+
   tests:
+    if: ${{ always() }}
     name: Tests
     runs-on: ubuntu-latest
     needs: [connector-tests, core-tests]
     steps:
-      - run: echo "All tests passed"
+      - run: exit 1
+        # see https://stackoverflow.com/a/67532120/4907315
+        if: >-
+          ${{
+               contains(needs.*.result, 'failure')
+            || contains(needs.*.result, 'cancelled')
+            || contains(needs.*.result, 'skipped')
+          }}