Skip to content

Extend timeout of run experiment test (e2e) #3713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattseddon merged 1 commit into from
Apr 19, 2023
Merged

Extend timeout of run experiment test (e2e) #3713

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions extension/src/test/e2e/extension.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ describe('Experiments Table Webview', function () {
})

it('should update with new data for each DVCLive step when an experiment is running', async function () {
this.timeout(180000)
this.timeout(210000)
await runModifiedExperiment()
await webview.focus()

Expand All @@ -102,7 +102,7 @@ describe('Experiments Table Webview', function () {

return currentRows.length >= initialRows + experimentRow
},
{ interval: 5000, timeout: 180000 }
{ interval: 5000, timeout: 210000 }
)

const currentRows = await webview.row$$
Expand All @@ -121,19 +121,15 @@ describe('Experiments Table Webview', function () {

return step === epochs - 1
},
{ interval: 5000, timeout: 180000 }
{ interval: 5000, timeout: 210000 }
)

await webview.unfocus()
await waitForDvcToFinish()
await webview.focus()

const finalRows = await webview.row$$

expect(finalRows.length).toStrictEqual(initialRows + experimentRow)
await webview.unfocus()
await closeAllEditors()
await waitForDvcToFinish()
await waitForDvcToFinish(90000)
const workbench = await browser.getWorkbench()
return workbench.executeCommand('Terminal: Kill All Terminals')
})
Expand Down
4 changes: 2 additions & 2 deletions extension/src/test/e2e/util.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,9 @@ const dvcIsWorking = async (): Promise<boolean> => {
)
}

export const waitForDvcToFinish = async (): Promise<void> => {
export const waitForDvcToFinish = async (timeout = 60000): Promise<void> => {
await browser.waitUntil(async () => !(await dvcIsWorking()), {
timeout: 60000
timeout
})
}

Expand Down