Skip to content

Conversation

@mattseddon
Copy link
Contributor

@mattseddon mattseddon commented Apr 19, 2023

2/2 main <- #3665 <- this

An attempt to fix the flaky e2e test (works fine locally).

@mattseddon mattseddon added the bug Something isn't working label Apr 19, 2023
@mattseddon mattseddon self-assigned this Apr 19, 2023
@mattseddon mattseddon changed the base branch from main to integrate-exp-show April 19, 2023 05:20
Copy link

@qlty-cloud-legacy qlty-cloud-legacy bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 37011 lines exceeds the maximum allowed for the inline comments feature.

@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit 76e445d and detected 3 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1
Duplication 2

The test coverage on the diff in this pull request is 94.9% (85% is the threshold).

This pull request will bring the total coverage in the repository to 94.7% (0.0% change).

View more on Code Climate.

@mattseddon mattseddon merged commit 5804573 into integrate-exp-show Apr 19, 2023
@mattseddon mattseddon deleted the fix-e2e branch April 19, 2023 18:57
mattseddon added a commit that referenced this pull request Apr 20, 2023
…outside the workspace) (#3665)

* wrap all loose test data in test data generator

* add new type

* duplicate required functions but use new data

* update test fixtures

* deduplicate functions

* remove checkpoints model and file system watcher (#3684)

* extend timeout of run experiment test (e2e) (#3713)

* prevent plotting of running experiments (#3712)

* trigger plot updates whenever commit data changes (#3715)

* update demo project and min required version of DVC

* fix experiment id for commits (shown in plots) (#3724)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants