Skip to content

Remove references to experiment checkpoints from walkthrough #3595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mattseddon merged 1 commit into from
Apr 1, 2023
Merged

Remove references to experiment checkpoints from walkthrough #3595

mattseddon merged 1 commit into from
Apr 1, 2023

Conversation

@mattseddon
Copy link
Contributor

@mattseddon mattseddon commented Mar 31, 2023 •
edited
Loading

2/3 #3585 <- #3591 <- this <- #3596

This PR removes references/screenshots of checkpoints from the walkthrough.

Screen.Recording.2023-03-31.at.2.01.11.pm.mov

Note: I have not removed every screenshot that contains references to checkpoints. E.g -

image

The reason for this is that the cost of recreation (for me anyway) is too high and there is some utility in the picture.

@mattseddon mattseddon self-assigned this Mar 31, 2023
@mattseddon mattseddon changed the base branch from main to add-experiment-middle-states March 31, 2023 03:04
@mattseddon mattseddon marked this pull request as ready for review March 31, 2023 03:05
@mattseddon mattseddon force-pushed the remove-checkpoints-from-docs branch from aeb2c49 to aed5006 Compare March 31, 2023 03:05
This was referenced Mar 31, 2023
Merged
Merged
julieg18
julieg18 approved these changes Mar 31, 2023
View reviewed changes
Copy link
Contributor

@julieg18 julieg18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Note: I have not removed every screenshot that contains references to checkpoints. E.g -
The reason for this is that the cost of recreation (for me anyway) is too high and there is some utility in the picture.

Using our figma resources, I created a version of this image with my mediocre figma skills without much trouble:

click-the-circle-beside-experiment-name

Will it work? I can also adjust it more to look more like our current one :)

@mattseddon
Copy link
Contributor Author

mattseddon commented Mar 31, 2023

Looks good!

Note: I have not removed every screenshot that contains references to checkpoints. E.g -
The reason for this is that the cost of recreation (for me anyway) is too high and there is some utility in the picture.

Using our figma resources, I created a version of this image with my mediocre figma skills without much trouble:

click-the-circle-beside-experiment-name

Will it work? I can also adjust it more to look more like our current one :)

Yes, it will, can you give me a tutorial? I'll do the rest

@mattseddon mattseddon force-pushed the add-experiment-middle-states branch from abe3cb3 to a9da396 Compare April 1, 2023 05:47
@mattseddon mattseddon force-pushed the remove-checkpoints-from-docs branch from aed5006 to a92d7a7 Compare April 1, 2023 05:48
Base automatically changed from add-experiment-middle-states to remove-checkpoints-from-webview April 1, 2023 07:13
@mattseddon mattseddon force-pushed the remove-checkpoints-from-docs branch from a92d7a7 to 0e0b656 Compare April 1, 2023 07:14
@mattseddon mattseddon merged commit 19c8ba1 into remove-checkpoints-from-webview Apr 1, 2023
@mattseddon mattseddon deleted the remove-checkpoints-from-docs branch April 1, 2023 07:14
@mattseddon mattseddon mentioned this pull request Apr 3, 2023
Merged
mattseddon added a commit that referenced this pull request Apr 3, 2023
@mattseddon
Remove experiment checkpoints from extension UI (#3585)
abfa8b0 
* Remove experiment checkpoints from table

* Remove experiment checkpoints from tree (#3587)

* Remove experiment checkpoints from filters (#3588)

* Remove experiment checkpoints from select experiments to plot (#3589)

* Remove experiment checkpoints from plot color collection (#3590)

* Add experiment state counts to commit record (#3591)

* Remove references to experiment checkpoints from walkthrough (#3595)

* Remove experiment checkpoints from table context menu (#3596)

* Remove checkpoints from custom plots (#3610)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@sroy3 sroy3 sroy3 approved these changes

@julieg18 julieg18 julieg18 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mattseddon mattseddon

Labels

🏠 housekeeping

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mattseddon @sroy3 @julieg18