Remove experiment checkpoints from extension UI #3585
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattseddon
force-pushed
the
remove-checkpoints-from-webview
branch
from
68178f3 to
56ebcb2
Compare
This was referenced Mar 30, 2023
This was referenced Mar 30, 2023
sroy3
approved these changes
Mar 30, 2023
This was referenced Mar 30, 2023
![qlty-cloud-legacy[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| }: { | ||
| selectedForPlotsCount: number | ||
| }) => { | ||
| export const Indicators = () => { |
There was a problem hiding this comment.
Function Indicators has 53 lines of code (exceeds 40 allowed). Consider refactoring.
mattseddon
changed the title
|
Code Climate has analyzed commit b78eadd and detected 1 issue on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 94.9% (-0.1% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the feature branch that closes #3577
Each commit in this PR relates to removal of checkpoints for another part of the UI.
Outstanding items once this is merged:
extension/src/experiments/model/collect.ts)ExperimentTypeenum