Skip to content

Make the plot sizing sliders sticky #3443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sroy3 merged 4 commits into from
Mar 13, 2023
Merged

Make the plot sizing sliders sticky #3443

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
59534a3
Make the plot sizing sliders sticky
Mar 10, 2023
4d03f58
Merge branch 'main' into sticky-size-sliders
Mar 13, 2023
182ea9f
Merge branch 'main' into sticky-size-sliders
sroy3 Mar 13, 2023
39ec522
Merge branch 'main' into sticky-size-sliders
sroy3 Mar 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions webview/src/plots/components/PlotsContainer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ export const PlotsContainer: React.FC<PlotsContainerProps> = ({
const maxNbPlotsPerRow = useSelector(
(state: PlotsState) => state.webview.maxNbPlotsPerRow
)
const ribbonHeight = useSelector((state: PlotsState) => state.ribbon.height)

useEffect(() => {
window.dispatchEvent(new Event('resize'))
Expand Down Expand Up @@ -116,6 +117,7 @@ export const PlotsContainer: React.FC<PlotsContainerProps> = ({
{changeNbItemsPerRow && hasItems && maxNbPlotsPerRow > 1 && (
<div
className={styles.nbItemsPerRowSlider}
style={{ top: ribbonHeight - 4 }}
data-testid="nb-items-per-row-slider"
>
<MinMaxSlider
Expand All @@ -125,6 +127,7 @@ export const PlotsContainer: React.FC<PlotsContainerProps> = ({
onChange={handleResize}
defaultValue={-nbItemsPerRow}
/>
main
</div>
)}
{open && (
Expand Down
8 changes: 7 additions & 1 deletion webview/src/plots/components/styles.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,9 +225,15 @@ $gap: 20px;
}

.nbItemsPerRowSlider {
position: sticky;
right: 0;
top: 0;
width: 100%;
display: flex;
justify-content: end;
margin: 20px;
padding: 20px;
background-color: $bg-color;
z-index: 3;
}

:global(.has-actions) {
Expand Down