CRM-12622 - CiviUnitTestCase - Promote sethtmlGlobals

When defining multiple cases in CRM_Report_Form_Contribute_Detail, the second case fails due to an uninitialized (lost?) global. api_v3_UFFieldTest seems to have a work-around. ``` 1) CRM_Report_Form_Contribute_DetailTest::testReportOutput with data set #1 ('CRM_Report_Form_Contribute_Detail', array(array('first_name', 'email', 'total_amount'), array('gte', 50)), 'fixtures/dataset.sql', 'fixtures/report.csv') Undefined index: _HTML_QuickForm_registered_rules /Applications/MAMP/htdocs/sites/all/modules/civicrm/packages/HTML/QuickForm/RuleRegistry.php:122 /Applications/MAMP/htdocs/sites/all/modules/civicrm/packages/HTML/QuickForm/RuleRegistry.php:98 /Applications/MAMP/htdocs/sites/all/modules/civicrm/packages/HTML/QuickForm.php:389 /Applications/MAMP/htdocs/sites/all/modules/civicrm/CRM/Core/Form.php:187 /Applications/MAMP/htdocs/sites/all/modules/civicrm/CRM/Core/Form.php:156 /Applications/MAMP/htdocs/sites/all/modules/civicrm/CRM/Report/Form.php:256 /Applications/MAMP/htdocs/sites/all/modules/civicrm/CRM/Report/Form/Contribute/Detail.php:362 /Applications/MAMP/htdocs/sites/all/modules/civicrm/CRM/Core/Controller.php:426 /Applications/MAMP/htdocs/sites/all/modules/civicrm/CRM/Core/Controller/Simple.php:79 /Applications/MAMP/htdocs/sites/all/modules/civicrm/tests/phpunit/CiviTest/CiviReportTestCase.php:43 /Applications/MAMP/htdocs/sites/all/modules/civicrm/tests/phpunit/CRM/Report/Form/Contribute/DetailTest.php:105 /Applications/MAMP/htdocs/sites/all/modules/civicrm/tools/scripts/phpunit:75 ``` ---------------------------------------- * CRM-12622: Create framework for example report data files http://issues.civicrm.org/jira/browse/CRM-12622
totten · Jul 30, 2013 · 5c2e58a · 5c2e58a
1 parent 25c8f5c
commit 5c2e58a
Show file tree

Hide file tree

Showing 3 changed files with 173 additions and 172 deletions.
diff --git a/tests/phpunit/CiviTest/CiviReportTestCase.php b/tests/phpunit/CiviTest/CiviReportTestCase.php
@@ -30,6 +30,7 @@
 class CiviReportTestCase extends CiviUnitTestCase {
   function setUp() {
     parent::setUp();
+    $this->_sethtmlGlobals();
   }
 
   function tearDown() {

diff --git a/tests/phpunit/CiviTest/CiviUnitTestCase.php b/tests/phpunit/CiviTest/CiviUnitTestCase.php
@@ -2267,6 +2267,178 @@ function deleteFromIDSArray() {
       }
     }
   }
+
+  /**
+   * FIXME: something NULLs $GLOBALS['_HTML_QuickForm_registered_rules'] when the tests are ran all together
+   * (NB unclear if this is still required)
+   */
+  function _sethtmlGlobals() {
+    $GLOBALS['_HTML_QuickForm_registered_rules'] = array(
+      'required' => array(
+        'html_quickform_rule_required',
+        'HTML/QuickForm/Rule/Required.php'
+      ),
+      'maxlength' => array(
+        'html_quickform_rule_range',
+        'HTML/QuickForm/Rule/Range.php'
+      ),
+      'minlength' => array(
+        'html_quickform_rule_range',
+        'HTML/QuickForm/Rule/Range.php'
+      ),
+      'rangelength' => array(
+        'html_quickform_rule_range',
+        'HTML/QuickForm/Rule/Range.php'
+      ),
+      'email' => array(
+        'html_quickform_rule_email',
+        'HTML/QuickForm/Rule/Email.php'
+      ),
+      'regex' => array(
+        'html_quickform_rule_regex',
+        'HTML/QuickForm/Rule/Regex.php'
+      ),
+      'lettersonly' => array(
+        'html_quickform_rule_regex',
+        'HTML/QuickForm/Rule/Regex.php'
+      ),
+      'alphanumeric' => array(
+        'html_quickform_rule_regex',
+        'HTML/QuickForm/Rule/Regex.php'
+      ),
+      'numeric' => array(
+        'html_quickform_rule_regex',
+        'HTML/QuickForm/Rule/Regex.php'
+      ),
+      'nopunctuation' => array(
+        'html_quickform_rule_regex',
+        'HTML/QuickForm/Rule/Regex.php'
+      ),
+      'nonzero' => array(
+        'html_quickform_rule_regex',
+        'HTML/QuickForm/Rule/Regex.php'
+      ),
+      'callback' => array(
+        'html_quickform_rule_callback',
+        'HTML/QuickForm/Rule/Callback.php'
+      ),
+      'compare' => array(
+        'html_quickform_rule_compare',
+        'HTML/QuickForm/Rule/Compare.php'
+      )
+    );
+    // FIXME: …ditto for $GLOBALS['HTML_QUICKFORM_ELEMENT_TYPES']
+    $GLOBALS['HTML_QUICKFORM_ELEMENT_TYPES'] = array(
+      'group' => array(
+        'HTML/QuickForm/group.php',
+        'HTML_QuickForm_group'
+      ),
+      'hidden' => array(
+        'HTML/QuickForm/hidden.php',
+        'HTML_QuickForm_hidden'
+      ),
+      'reset' => array(
+        'HTML/QuickForm/reset.php',
+        'HTML_QuickForm_reset'
+      ),
+      'checkbox' => array(
+        'HTML/QuickForm/checkbox.php',
+        'HTML_QuickForm_checkbox'
+      ),
+      'file' => array(
+        'HTML/QuickForm/file.php',
+        'HTML_QuickForm_file'
+      ),
+      'image' => array(
+        'HTML/QuickForm/image.php',
+        'HTML_QuickForm_image'
+      ),
+      'password' => array(
+        'HTML/QuickForm/password.php',
+        'HTML_QuickForm_password'
+      ),
+      'radio' => array(
+        'HTML/QuickForm/radio.php',
+        'HTML_QuickForm_radio'
+      ),
+      'button' => array(
+        'HTML/QuickForm/button.php',
+        'HTML_QuickForm_button'
+      ),
+      'submit' => array(
+        'HTML/QuickForm/submit.php',
+        'HTML_QuickForm_submit'
+      ),
+      'select' => array(
+        'HTML/QuickForm/select.php',
+        'HTML_QuickForm_select'
+      ),
+      'hiddenselect' => array(
+        'HTML/QuickForm/hiddenselect.php',
+        'HTML_QuickForm_hiddenselect'
+      ),
+      'text' => array(
+        'HTML/QuickForm/text.php',
+        'HTML_QuickForm_text'
+      ),
+      'textarea' => array(
+        'HTML/QuickForm/textarea.php',
+        'HTML_QuickForm_textarea'
+      ),
+      'fckeditor' => array(
+        'HTML/QuickForm/fckeditor.php',
+        'HTML_QuickForm_FCKEditor'
+      ),
+      'tinymce' => array(
+        'HTML/QuickForm/tinymce.php',
+        'HTML_QuickForm_TinyMCE'
+      ),
+      'dojoeditor' => array(
+        'HTML/QuickForm/dojoeditor.php',
+        'HTML_QuickForm_dojoeditor'
+      ),
+      'link' => array(
+        'HTML/QuickForm/link.php',
+        'HTML_QuickForm_link'
+      ),
+      'advcheckbox' => array(
+        'HTML/QuickForm/advcheckbox.php',
+        'HTML_QuickForm_advcheckbox'
+      ),
+      'date' => array(
+        'HTML/QuickForm/date.php',
+        'HTML_QuickForm_date'
+      ),
+      'static' => array(
+        'HTML/QuickForm/static.php',
+        'HTML_QuickForm_static'
+      ),
+      'header' => array(
+        'HTML/QuickForm/header.php',
+        'HTML_QuickForm_header'
+      ),
+      'html' => array(
+        'HTML/QuickForm/html.php',
+        'HTML_QuickForm_html'
+      ),
+      'hierselect' => array(
+        'HTML/QuickForm/hierselect.php',
+        'HTML_QuickForm_hierselect'
+      ),
+      'autocomplete' => array(
+        'HTML/QuickForm/autocomplete.php',
+        'HTML_QuickForm_autocomplete'
+      ),
+      'xbutton' => array(
+        'HTML/QuickForm/xbutton.php',
+        'HTML_QuickForm_xbutton'
+      ),
+      'advmultiselect' => array(
+        'HTML/QuickForm/advmultiselect.php',
+        'HTML_QuickForm_advmultiselect'
+      )
+    );
+  }
 }
 
 function CiviUnitTestCase_fatalErrorHandler($message) {

diff --git a/tests/phpunit/api/v3/UFFieldTest.php b/tests/phpunit/api/v3/UFFieldTest.php
@@ -216,176 +216,4 @@ public function testReplaceUFFields() {
       }
     }
   }
-
-  /**
-   * FIXME: something NULLs $GLOBALS['_HTML_QuickForm_registered_rules'] when the tests are ran all together
-   * (NB unclear if this is still required)
-   */
-  function _sethtmlGlobals() {
-    $GLOBALS['_HTML_QuickForm_registered_rules'] = array(
-      'required' => array(
-        'html_quickform_rule_required',
-        'HTML/QuickForm/Rule/Required.php'
-      ),
-      'maxlength' => array(
-        'html_quickform_rule_range',
-        'HTML/QuickForm/Rule/Range.php'
-      ),
-      'minlength' => array(
-        'html_quickform_rule_range',
-        'HTML/QuickForm/Rule/Range.php'
-      ),
-      'rangelength' => array(
-        'html_quickform_rule_range',
-        'HTML/QuickForm/Rule/Range.php'
-      ),
-      'email' => array(
-        'html_quickform_rule_email',
-        'HTML/QuickForm/Rule/Email.php'
-      ),
-      'regex' => array(
-        'html_quickform_rule_regex',
-        'HTML/QuickForm/Rule/Regex.php'
-      ),
-      'lettersonly' => array(
-        'html_quickform_rule_regex',
-        'HTML/QuickForm/Rule/Regex.php'
-      ),
-      'alphanumeric' => array(
-        'html_quickform_rule_regex',
-        'HTML/QuickForm/Rule/Regex.php'
-      ),
-      'numeric' => array(
-        'html_quickform_rule_regex',
-        'HTML/QuickForm/Rule/Regex.php'
-      ),
-      'nopunctuation' => array(
-        'html_quickform_rule_regex',
-        'HTML/QuickForm/Rule/Regex.php'
-      ),
-      'nonzero' => array(
-        'html_quickform_rule_regex',
-        'HTML/QuickForm/Rule/Regex.php'
-      ),
-      'callback' => array(
-        'html_quickform_rule_callback',
-        'HTML/QuickForm/Rule/Callback.php'
-      ),
-      'compare' => array(
-        'html_quickform_rule_compare',
-        'HTML/QuickForm/Rule/Compare.php'
-      )
-    );
-    // FIXME: …ditto for $GLOBALS['HTML_QUICKFORM_ELEMENT_TYPES']
-    $GLOBALS['HTML_QUICKFORM_ELEMENT_TYPES'] = array(
-      'group' => array(
-        'HTML/QuickForm/group.php',
-        'HTML_QuickForm_group'
-      ),
-      'hidden' => array(
-        'HTML/QuickForm/hidden.php',
-        'HTML_QuickForm_hidden'
-      ),
-      'reset' => array(
-        'HTML/QuickForm/reset.php',
-        'HTML_QuickForm_reset'
-      ),
-      'checkbox' => array(
-        'HTML/QuickForm/checkbox.php',
-        'HTML_QuickForm_checkbox'
-      ),
-      'file' => array(
-        'HTML/QuickForm/file.php',
-        'HTML_QuickForm_file'
-      ),
-      'image' => array(
-        'HTML/QuickForm/image.php',
-        'HTML_QuickForm_image'
-      ),
-      'password' => array(
-        'HTML/QuickForm/password.php',
-        'HTML_QuickForm_password'
-      ),
-      'radio' => array(
-        'HTML/QuickForm/radio.php',
-        'HTML_QuickForm_radio'
-      ),
-      'button' => array(
-        'HTML/QuickForm/button.php',
-        'HTML_QuickForm_button'
-      ),
-      'submit' => array(
-        'HTML/QuickForm/submit.php',
-        'HTML_QuickForm_submit'
-      ),
-      'select' => array(
-        'HTML/QuickForm/select.php',
-        'HTML_QuickForm_select'
-      ),
-      'hiddenselect' => array(
-        'HTML/QuickForm/hiddenselect.php',
-        'HTML_QuickForm_hiddenselect'
-      ),
-      'text' => array(
-        'HTML/QuickForm/text.php',
-        'HTML_QuickForm_text'
-      ),
-      'textarea' => array(
-        'HTML/QuickForm/textarea.php',
-        'HTML_QuickForm_textarea'
-      ),
-      'fckeditor' => array(
-        'HTML/QuickForm/fckeditor.php',
-        'HTML_QuickForm_FCKEditor'
-      ),
-      'tinymce' => array(
-        'HTML/QuickForm/tinymce.php',
-        'HTML_QuickForm_TinyMCE'
-      ),
-      'dojoeditor' => array(
-        'HTML/QuickForm/dojoeditor.php',
-        'HTML_QuickForm_dojoeditor'
-      ),
-      'link' => array(
-        'HTML/QuickForm/link.php',
-        'HTML_QuickForm_link'
-      ),
-      'advcheckbox' => array(
-        'HTML/QuickForm/advcheckbox.php',
-        'HTML_QuickForm_advcheckbox'
-      ),
-      'date' => array(
-        'HTML/QuickForm/date.php',
-        'HTML_QuickForm_date'
-      ),
-      'static' => array(
-        'HTML/QuickForm/static.php',
-        'HTML_QuickForm_static'
-      ),
-      'header' => array(
-        'HTML/QuickForm/header.php',
-        'HTML_QuickForm_header'
-      ),
-      'html' => array(
-        'HTML/QuickForm/html.php',
-        'HTML_QuickForm_html'
-      ),
-      'hierselect' => array(
-        'HTML/QuickForm/hierselect.php',
-        'HTML_QuickForm_hierselect'
-      ),
-      'autocomplete' => array(
-        'HTML/QuickForm/autocomplete.php',
-        'HTML_QuickForm_autocomplete'
-      ),
-      'xbutton' => array(
-        'HTML/QuickForm/xbutton.php',
-        'HTML_QuickForm_xbutton'
-      ),
-      'advmultiselect' => array(
-        'HTML/QuickForm/advmultiselect.php',
-        'HTML_QuickForm_advmultiselect'
-      )
-    );
-  }
 }