CRM_Utils_GlobalStack - Allow top-level vars

totten · Jul 30, 2013 · 25c8f5c · 25c8f5c
1 parent 85f9c0f
commit 25c8f5c
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 5 deletions.
diff --git a/CRM/Utils/GlobalStack.php b/CRM/Utils/GlobalStack.php
@@ -80,17 +80,25 @@ public function pop() {
   public function createBackup($new) {
     $frame = array();
     foreach ($new as $globalKey => $values) {
-      foreach ($values as $key => $value) {
-        $frame[$globalKey][$key] = CRM_Utils_Array::value($key, $GLOBALS[$globalKey]);
+      if (is_array($values)) {
+        foreach ($values as $key => $value) {
+          $frame[$globalKey][$key] = CRM_Utils_Array::value($key, $GLOBALS[$globalKey]);
+        }
+      } else {
+        $frame[$globalKey] = CRM_Utils_Array::value($globalKey, $GLOBALS);
       }
     }
     return $frame;
   }
 
   public function applyFrame($newFrame) {
     foreach ($newFrame as $globalKey => $values) {
-      foreach ($values as $key => $value) {
-        $GLOBALS[$globalKey][$key] = $value;
+      if (is_array($values)) {
+        foreach ($values as $key => $value) {
+          $GLOBALS[$globalKey][$key] = $value;
+        }
+      } else {
+        $GLOBALS[$globalKey] = $values;
       }
     }
   }

diff --git a/tests/phpunit/CRM/Utils/GlobalStackTest.php b/tests/phpunit/CRM/Utils/GlobalStackTest.php
@@ -5,30 +5,35 @@
 class CRM_Utils_GlobalStackTest extends CiviUnitTestCase {
 
   public function testPushPop() {
-    global $FOO;
+    global $FOO, $EXTRA;
 
     $FOO['bar'] = 1;
     $FOO['whiz'] = 1;
+    $EXTRA = 1;
 
     $this->assertEquals(1, $FOO['bar']);
     $this->assertEquals(1, $FOO['whiz']);
     $this->assertFalse(isset($FOO['bang']));
+    $this->assertEquals(1, $EXTRA);
 
     CRM_Utils_GlobalStack::singleton()->push(array(
       'FOO' => array(
         'bar' => 2,
         'bang' => 2,
       ),
+      'EXTRA' => 2,
     ));
 
     $this->assertEquals(2, $FOO['bar']);
     $this->assertEquals(1, $FOO['whiz']);
     $this->assertEquals(2, $FOO['bang']);
+    $this->assertEquals(2, $EXTRA);
 
     CRM_Utils_GlobalStack::singleton()->pop();
 
     $this->assertEquals(1, $FOO['bar']);
     $this->assertEquals(1, $FOO['whiz']);
     $this->assertEquals(NULL, $FOO['bang']);
+    $this->assertEquals(1, $EXTRA);
   }
 }