fix(suspensive.org): resolve locale initialization issue #1311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
People can be co-author:
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
kangju2000
changed the title
|
Size Change: 0 B Total Size: 64.5 kB ℹ️ View Unchanged
|
CodSpeed Performance ReportMerging #1311 will create unknown performance changesComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1311 +/- ##
=======================================
Coverage 78.37% 78.37%
=======================================
Files 71 71
Lines 615 615
Branches 143 143
=======================================
Hits 482 482
Misses 127 127
Partials 6 6
|
manudeli
approved these changes
Oct 13, 2024
Comment on lines
-1
to
-24
| import { type NextRequest, NextResponse } from 'next/server' | ||
|
|
||
| const PUBLIC_FILE = /\.(.*)$/ | ||
|
|
||
| export function middleware(req: NextRequest) { | ||
| if ( | ||
| req.nextUrl.pathname.startsWith('/_next') || | ||
| req.nextUrl.pathname.includes('/api/') || | ||
| PUBLIC_FILE.test(req.nextUrl.pathname) | ||
| ) { | ||
| return | ||
| } | ||
|
|
||
| if ( | ||
| !( | ||
| req.nextUrl.pathname.startsWith('/en') || | ||
| req.nextUrl.pathname.startsWith('/ko') | ||
| ) | ||
| ) { | ||
| return NextResponse.redirect( | ||
| new URL(`/en${req.nextUrl.pathname}${req.nextUrl.search}`, req.url) | ||
| ) | ||
| } | ||
| } |
There was a problem hiding this comment.
Simple and auto detect locale..! not only redirecting English
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
I address an issue where undefined locale URLs defaulted to 'en' in Nextra documentation. I've implemented Nextra's middleware to recognize locale cookies.
2024-10-13.8.18.33.mov
[AS-IS]
[TO-BE]
icon.svg)Issue
Nextra styles may appear broken in development. See Issue #3357. Could you please confirm if you're experiencing this as well?
PR Checklist