Skip to content

chore: remove cache pacakge #1279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 29, 2024
Merged

chore: remove cache pacakge #1279

merged 2 commits into from
Sep 29, 2024

Conversation

SEOKKAMONI
Copy link
Contributor

@SEOKKAMONI SEOKKAMONI commented Sep 28, 2024

Overview

  • remove cache pacakge

Creating a library for caching turned out to be a much more challenging task than we initially expected, as it felt like creating something from nothing. After extensive discussions and considering our limited resources and the complexity of the project, we have decided to conclude the work at this point and discontinue further development.

PR Checklist

  • I did below actions if need
  1. I read the Contributing Guide
  2. I added documents and tests.

@SEOKKAMONI SEOKKAMONI self-assigned this Sep 28, 2024
Copy link

coauthors bot commented Sep 28, 2024

People can be co-author:

Candidate Reasons Count Add this as commit message
@manudeli #1279 (comment) #1279 (review) #1279 (review) 3 Co-authored-by: manudeli <[email protected]>
@SEOKKAMONI #1279 1 Co-authored-by: SEOKKAMONI <[email protected]>
@codecov-commenter #1279 (comment) 1 Co-authored-by: codecov-commenter <[email protected]>

Copy link

changeset-bot bot commented Sep 28, 2024

⚠️ No Changeset found

Latest commit: b86f2ac

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Sep 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
suspensive.org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 29, 2024 10:09am
v1.suspensive.org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 29, 2024 10:09am
visualization.suspensive.org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 29, 2024 10:09am

Copy link

github-actions bot commented Sep 28, 2024

Size Change: -9.04 kB (-9.56%) 👏

Total Size: 85.5 kB

Filename Size Change
packages/cache/dist/Cache.cjs 0 B -1.7 kB (removed) 🏆
packages/cache/dist/Cache.js 0 B -129 B (removed) 🏆
packages/cache/dist/cacheOptions.cjs 0 B -539 B (removed) 🏆
packages/cache/dist/cacheOptions.js 0 B -136 B (removed) 🏆
packages/cache/dist/CacheProvider.cjs 0 B -655 B (removed) 🏆
packages/cache/dist/CacheProvider.js 0 B -147 B (removed) 🏆
packages/cache/dist/index.cjs 0 B -2.2 kB (removed) 🏆
packages/cache/dist/index.js 0 B -240 B (removed) 🏆
packages/cache/dist/Read.cjs 0 B -982 B (removed) 🏆
packages/cache/dist/Read.js 0 B -157 B (removed) 🏆
packages/cache/dist/types.cjs 0 B -416 B (removed) 🏆
packages/cache/dist/types.js 0 B -66 B (removed) 🏆
packages/cache/dist/useCache.cjs 0 B -652 B (removed) 🏆
packages/cache/dist/useCache.js 0 B -142 B (removed) 🏆
packages/cache/dist/useRead.cjs 0 B -728 B (removed) 🏆
packages/cache/dist/useRead.js 0 B -150 B (removed) 🏆
ℹ️ View Unchanged
Filename Size
packages/jotai/dist/Atom.cjs 660 B
packages/jotai/dist/Atom.js 115 B
packages/jotai/dist/AtomValue.cjs 647 B
packages/jotai/dist/AtomValue.js 120 B
packages/jotai/dist/index.cjs 755 B
packages/jotai/dist/index.js 158 B
packages/jotai/dist/SetAtom.cjs 645 B
packages/jotai/dist/SetAtom.js 118 B
packages/react-dom/dist/index.cjs 2.11 kB
packages/react-dom/dist/index.js 139 B
packages/react-dom/dist/InView.cjs 2.1 kB
packages/react-dom/dist/InView.js 130 B
packages/react-dom/dist/useInView.cjs 1.87 kB
packages/react-dom/dist/useInView.js 120 B
packages/react-image/dist/index.cjs 1.54 kB
packages/react-image/dist/index.js 140 B
packages/react-image/dist/Load.cjs 1.32 kB
packages/react-image/dist/Load.js 126 B
packages/react-image/dist/SuspenseImage.cjs 1.53 kB
packages/react-image/dist/SuspenseImage.js 137 B
packages/react-native/dist/index.cjs 619 B
packages/react-native/dist/index.js 122 B
packages/react-native/dist/TestText.cjs 612 B
packages/react-native/dist/TestText.js 119 B
packages/react-query-4/dist/index.cjs 1.86 kB
packages/react-query-4/dist/index.js 394 B
packages/react-query-4/dist/infiniteQueryOptions.cjs 548 B
packages/react-query-4/dist/infiniteQueryOptions.js 143 B
packages/react-query-4/dist/Mutation.cjs 821 B
packages/react-query-4/dist/Mutation.js 132 B
packages/react-query-4/dist/PrefetchInfiniteQuery.cjs 722 B
packages/react-query-4/dist/PrefetchInfiniteQuery.js 155 B
packages/react-query-4/dist/PrefetchQuery.cjs 712 B
packages/react-query-4/dist/PrefetchQuery.js 147 B
packages/react-query-4/dist/QueryClientConsumer.cjs 665 B
packages/react-query-4/dist/QueryClientConsumer.js 140 B
packages/react-query-4/dist/QueryErrorBoundary.cjs 1.12 kB
packages/react-query-4/dist/QueryErrorBoundary.js 142 B
packages/react-query-4/dist/queryOptions.cjs 540 B
packages/react-query-4/dist/queryOptions.js 135 B
packages/react-query-4/dist/SuspenseInfiniteQuery.cjs 1.05 kB
packages/react-query-4/dist/SuspenseInfiniteQuery.js 154 B
packages/react-query-4/dist/SuspenseQueries.cjs 923 B
packages/react-query-4/dist/SuspenseQueries.js 149 B
packages/react-query-4/dist/SuspenseQuery.cjs 1.04 kB
packages/react-query-4/dist/SuspenseQuery.js 147 B
packages/react-query-4/dist/usePrefetchInfiniteQuery.cjs 648 B
packages/react-query-4/dist/usePrefetchInfiniteQuery.js 148 B
packages/react-query-4/dist/usePrefetchQuery.cjs 639 B
packages/react-query-4/dist/usePrefetchQuery.js 140 B
packages/react-query-4/dist/useSuspenseInfiniteQuery.cjs 833 B
packages/react-query-4/dist/useSuspenseInfiniteQuery.js 147 B
packages/react-query-4/dist/useSuspenseQueries.cjs 833 B
packages/react-query-4/dist/useSuspenseQueries.js 142 B
packages/react-query-4/dist/useSuspenseQuery.cjs 824 B
packages/react-query-4/dist/useSuspenseQuery.js 140 B
packages/react-query-5/dist/index.cjs 1.76 kB
packages/react-query-5/dist/index.js 391 B
packages/react-query-5/dist/infiniteQueryOptions.cjs 573 B
packages/react-query-5/dist/infiniteQueryOptions.js 144 B
packages/react-query-5/dist/Mutation.cjs 821 B
packages/react-query-5/dist/Mutation.js 132 B
packages/react-query-5/dist/PrefetchInfiniteQuery.cjs 647 B
packages/react-query-5/dist/PrefetchInfiniteQuery.js 145 B
packages/react-query-5/dist/PrefetchQuery.cjs 639 B
packages/react-query-5/dist/PrefetchQuery.js 137 B
packages/react-query-5/dist/QueryClientConsumer.cjs 663 B
packages/react-query-5/dist/QueryClientConsumer.js 140 B
packages/react-query-5/dist/QueryErrorBoundary.cjs 1.12 kB
packages/react-query-5/dist/QueryErrorBoundary.js 142 B
packages/react-query-5/dist/queryOptions.cjs 563 B
packages/react-query-5/dist/queryOptions.js 136 B
packages/react-query-5/dist/SuspenseInfiniteQuery.cjs 833 B
packages/react-query-5/dist/SuspenseInfiniteQuery.js 145 B
packages/react-query-5/dist/SuspenseQueries.cjs 671 B
packages/react-query-5/dist/SuspenseQueries.js 139 B
packages/react-query-5/dist/SuspenseQuery.cjs 825 B
packages/react-query-5/dist/SuspenseQuery.js 137 B
packages/react-query-5/dist/usePrefetchInfiniteQuery.cjs 577 B
packages/react-query-5/dist/usePrefetchInfiniteQuery.js 148 B
packages/react-query-5/dist/usePrefetchQuery.cjs 569 B
packages/react-query-5/dist/usePrefetchQuery.js 140 B
packages/react-query-5/dist/useSuspenseInfiniteQuery.cjs 577 B
packages/react-query-5/dist/useSuspenseInfiniteQuery.js 148 B
packages/react-query-5/dist/useSuspenseQueries.cjs 571 B
packages/react-query-5/dist/useSuspenseQueries.js 142 B
packages/react-query-5/dist/useSuspenseQuery.cjs 569 B
packages/react-query-5/dist/useSuspenseQuery.js 140 B
packages/react-query-next-experimental-4/dist/htmlescape.cjs 656 B
packages/react-query-next-experimental-4/dist/htmlescape.js 133 B
packages/react-query-next-experimental-4/dist/HydrationStreamProvider.cjs 1.79 kB
packages/react-query-next-experimental-4/dist/HydrationStreamProvider.js 156 B
packages/react-query-next-experimental-4/dist/index.cjs 2.41 kB
packages/react-query-next-experimental-4/dist/index.js 162 B
packages/react-query-next-experimental-4/dist/ReactQueryStreamedHydration.cjs 2.41 kB
packages/react-query-next-experimental-4/dist/ReactQueryStreamedHydration.js 164 B
packages/react-query-next-experimental/dist/index.cjs 595 B
packages/react-query-next-experimental/dist/index.js 161 B
packages/react-query/dist/index.cjs 551 B
packages/react-query/dist/index.js 121 B
packages/react-query/dist/v4.cjs 550 B
packages/react-query/dist/v4.js 116 B
packages/react-query/dist/v5.cjs 550 B
packages/react-query/dist/v5.js 116 B
packages/react/dist/ClientOnly.cjs 736 B
packages/react/dist/ClientOnly.js 141 B
packages/react/dist/DefaultProps.cjs 1.05 kB
packages/react/dist/DefaultProps.js 167 B
packages/react/dist/Delay.cjs 1.11 kB
packages/react/dist/Delay.js 149 B
packages/react/dist/DevMode.cjs 530 B
packages/react/dist/DevMode.js 131 B
packages/react/dist/ErrorBoundary.cjs 2.74 kB
packages/react/dist/ErrorBoundary.js 206 B
packages/react/dist/ErrorBoundaryGroup.cjs 1.37 kB
packages/react/dist/ErrorBoundaryGroup.js 180 B
packages/react/dist/index.cjs 4.19 kB
packages/react/dist/index.js 369 B
packages/react/dist/Suspense.cjs 1.3 kB
packages/react/dist/Suspense.js 172 B
packages/react/dist/Suspensive.cjs 1.26 kB
packages/react/dist/Suspensive.js 175 B
packages/react/dist/wrap.cjs 3.67 kB
packages/react/dist/wrap.js 209 B
packages/utils/dist/ConstructorType.cjs 424 B
packages/utils/dist/ConstructorType.js 76 B
packages/utils/dist/increase.cjs 533 B
packages/utils/dist/increase.js 119 B
packages/utils/dist/index.cjs 1.58 kB
packages/utils/dist/index.js 926 B
packages/utils/dist/noop.cjs 522 B
packages/utils/dist/noop.js 115 B
packages/utils/dist/Nullable.cjs 419 B
packages/utils/dist/Nullable.js 69 B
packages/utils/dist/OmitKeyof.cjs 420 B
packages/utils/dist/OmitKeyof.js 70 B
packages/utils/dist/RequiredKeyof.cjs 425 B
packages/utils/dist/RequiredKeyof.js 74 B
packages/utils/dist/useIsomorphicLayoutEffect.cjs 588 B
packages/utils/dist/useIsomorphicLayoutEffect.js 136 B
packages/utils/dist/usePreservedCallback.cjs 697 B
packages/utils/dist/usePreservedCallback.js 144 B
packages/utils/dist/useTimeout.cjs 769 B
packages/utils/dist/useTimeout.js 144 B

compressed-size-action

Copy link

codspeed-hq bot commented Sep 28, 2024

CodSpeed Performance Report

Merging #1279 will create unknown performance changes

Comparing remove/cache (b86f2ac) with main (5d81410)

Summary

⚠️ No benchmarks were detected in both the base of the PR and the PR.

@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.58%. Comparing base (5d81410) to head (b86f2ac).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1279      +/-   ##
==========================================
- Coverage   73.04%   69.58%   -3.46%     
==========================================
  Files          83       73      -10     
  Lines         831      730     -101     
  Branches      183      166      -17     
==========================================
- Hits          607      508      -99     
+ Misses        200      198       -2     
  Partials       24       24              
Components Coverage Δ
@suspensive/utils 47.16% <ø> (ø)
@suspensive/react 100.00% <ø> (ø)
@suspensive/react-dom 96.66% <ø> (ø)
@suspensive/react-native 100.00% <ø> (ø)
@suspensive/react-query 72.09% <ø> (ø)
@suspensive/react-query-4 0.00% <ø> (ø)
@suspensive/react-query-5 0.00% <ø> (ø)
@suspensive/react-query-next-experimental ∅ <ø> (∅)
@suspensive/react-query-next-experimental-4 6.15% <ø> (ø)
@suspensive/jotai 0.00% <ø> (ø)
@suspensive/react-image 80.39% <ø> (ø)

Copy link
Member

@manudeli manudeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it was a good attempt because it allowed us to cross off one of the various options for a better direction. Thanks 🙇

@manudeli manudeli merged commit 7c6c3b1 into main Sep 29, 2024
18 checks passed
@manudeli manudeli deleted the remove/cache branch September 29, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants