Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: eslint CI 오류 수정 #203

Merged
merged 2 commits into from
Jul 30, 2024
Merged

Conversation

kangju2000
Copy link
Contributor

@kangju2000 kangju2000 commented Jul 27, 2024

Overview

Related to #173

  • eslint 및 연관된 라이브러리 업데이트

[AS-IS]

현재 CI에서 다음 사진과 같은 warning이 나타나 제대로 동작하지 않고 있습니다.

image

[TO-BE]

typescript-eslint v7.2.0부터 5.4.x 버전을 지원하고 있기 때문에, 7버전으로 업그레이드를 진행했니다.

또한, eslint의 버전을 7 -> 8로 변경했습니다. 버전업으로 인한 문제가 우려되어 마이그레이션 문서를 첨부합니다.

스크린샷 2024-07-27 오후 4 12 06

PR Checklist

  • I read and included theses actions below
  1. I have read the Contributing Guide
  2. I have written documents and tests, if needed.

Copy link

changeset-bot bot commented Jul 27, 2024

🦋 Changeset detected

Latest commit: b227049

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jul 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
es-hangul ❌ Failed (Inspect) Jul 27, 2024 6:55am

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.18%. Comparing base (b6cde8e) to head (b227049).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #203   +/-   ##
=======================================
  Coverage   95.18%   95.18%           
=======================================
  Files          17       17           
  Lines         291      291           
  Branches       67       67           
=======================================
  Hits          277      277           
  Misses         13       13           
  Partials        1        1           

Comment on lines +21 to +25
settings: {
next: {
rootDir: 'docs/',
},
},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

문서에 변경이 있을 때 다음과 같은 warning이 나타납니다.

Pages directory cannot be found at /home/circleci/project/pages or /home/circleci/project/src/pages. If using a custom path, please configure with the no-html-link-for-pages rule in your eslint config file.

이를 공식문서를 참고하여 해결합니다.

@@ -16,6 +16,6 @@
"@/*": ["./src/*"]
}
},
"include": ["next-env.d.ts", "**/*.ts", "**/*.tsx", "src/pages/index.mdx"],
"include": ["next-env.d.ts", "next.config.js", "**/*.ts", "**/*.tsx", "src/pages/index.mdx"],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

next.config.js를 수정했을 때 CI에서 아래와 같은 에러가 나타나고 있어 tsconfig.json을 수정합니다.

/home/circleci/project/docs/next.config.js
0:0 error Parsing error: ESLint was configured to run on <tsconfigRootDir>/docs/next.config.js using parserOptions.project: /docs/tsconfig.json
However, that TSConfig does not include this file. Either:

Copy link
Member

@okinawaa okinawaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

너무 감사합니다!! 🙏

@okinawaa okinawaa merged commit fbe3ad6 into toss:main Jul 30, 2024
9 of 10 checks passed
@github-actions github-actions bot mentioned this pull request Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants