-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: eslint CI 오류 수정 #203
fix: eslint CI 오류 수정 #203
Conversation
🦋 Changeset detectedLatest commit: b227049 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #203 +/- ##
=======================================
Coverage 95.18% 95.18%
=======================================
Files 17 17
Lines 291 291
Branches 67 67
=======================================
Hits 277 277
Misses 13 13
Partials 1 1 |
settings: { | ||
next: { | ||
rootDir: 'docs/', | ||
}, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
문서에 변경이 있을 때 다음과 같은 warning이 나타납니다.
Pages directory cannot be found at /home/circleci/project/pages or /home/circleci/project/src/pages. If using a custom path, please configure with the
no-html-link-for-pages
rule in your eslint config file.
이를 공식문서를 참고하여 해결합니다.
@@ -16,6 +16,6 @@ | |||
"@/*": ["./src/*"] | |||
} | |||
}, | |||
"include": ["next-env.d.ts", "**/*.ts", "**/*.tsx", "src/pages/index.mdx"], | |||
"include": ["next-env.d.ts", "next.config.js", "**/*.ts", "**/*.tsx", "src/pages/index.mdx"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
next.config.js를 수정했을 때 CI에서 아래와 같은 에러가 나타나고 있어 tsconfig.json을 수정합니다.
/home/circleci/project/docs/next.config.js
0:0 error Parsing error: ESLint was configured to run on<tsconfigRootDir>/docs/next.config.js
usingparserOptions.project
: /docs/tsconfig.json
However, that TSConfig does not include this file. Either:
- Change ESLint's list of included files to not include this file
- Change that TSConfig to include this file
- Create a new TSConfig that includes this file and include it in your parserOptions.project
See the typescript-eslint docs for more info: https://typescript-eslint.io/linting/troubleshooting#i-get-errors-telling-me-eslint-was-configured-to-run--however-that-tsconfig-does-not--none-of-those-tsconfigs-include-this-file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
너무 감사합니다!! 🙏
Overview
Related to #173
[AS-IS]
현재 CI에서 다음 사진과 같은 warning이 나타나 제대로 동작하지 않고 있습니다.
[TO-BE]
typescript-eslint v7.2.0부터 5.4.x 버전을 지원하고 있기 때문에, 7버전으로 업그레이드를 진행했니다.
또한, eslint의 버전을 7 -> 8로 변경했습니다. 버전업으로 인한 문제가 우려되어 마이그레이션 문서를 첨부합니다.
PR Checklist