Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenSSL 3.2 compatibility #3357

Merged
merged 1 commit into from
Mar 3, 2024
Merged

OpenSSL 3.2 compatibility #3357

merged 1 commit into from
Mar 3, 2024

Conversation

danigm
Copy link
Contributor

@danigm danigm commented Jan 15, 2024

Fix #3355

@bdarnell
Copy link
Member

bdarnell commented Mar 3, 2024

My initial reaction was that the change from SSL_ERR_SSL to SSL_ERR_SYSCALL seems fishy, but it looks like OpenSSL is known to return SSL_ERR_SYSCALL in some (unspecified) cases for failed cert verification since at least version 3.1 (python/cpython#107077). Quietly logging SSL_ERR_SYSCALL here (whether it's a cert error or not) seems reasonable since that's what we do with socket.error (which is how most of our actual syscall errors would show up here).

@bdarnell bdarnell merged commit 464f608 into tornadoweb:master Mar 3, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test fail with openssl 3.2
2 participants