Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test fail with openssl 3.2 #3355

Closed
danigm opened this issue Jan 11, 2024 · 1 comment · Fixed by #3357
Closed

Test fail with openssl 3.2 #3355

danigm opened this issue Jan 11, 2024 · 1 comment · Fixed by #3357

Comments

@danigm
Copy link
Contributor

danigm commented Jan 11, 2024

One test is failing when running the test suite in openSUSE Tumbleweed with openssl 3.2:

FAIL: test_error_logging (tornado.test.simple_httpclient_test.SimpleHTTPSClientTestCase.test_error_logging)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/abuild/rpmbuild/BUILD/tornado-6.4/tornado/testing.py", line 102, in __call__
    result = self.orig_method(*args, **kwargs)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/abuild/rpmbuild/BUILD/tornado-6.4/tornado/test/simple_httpclient_test.py", line 573, in test_error_logging
    self.assertFalse(expect_log.logged_stack)
AssertionError: True is not false

Looks like the new openssl returns a different error code in this case when the certification is not valid and instead of returning
ssl.SSL_ERROR_SSL it's returning ssl.SSL_ERROR_SYSCALL, in the iostream.py

@krassowski
Copy link

The unhandled error appears to to break fetching for downstreams (jupyterlab/jupyterlab#15602).

danigm added a commit to danigm/tornado that referenced this issue Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants