chore: add support for v0.18.0#857
Merged
tjohnson31415 merged 10 commits intotorch-spyre:mainfrom Mar 25, 2026
Merged
Conversation
|
👋 Hi! Thank you for contributing to vLLM support on Spyre. We also recommend installing prek and configuring it to check your code before every local commit. |
Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com>
rafvasq
force-pushed
the
support-v0.18.0
branch
from
6fb6d7e to
98e417b
Compare
Co-authored-by: Max de Bayser <mbayser@br.ibm.com> Co-authored-by: Rafael Vasquez <rafvasq21@gmail.com> Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com>
rafvasq
force-pushed
the
support-v0.18.0
branch
from
77179e2 to
5e3cabf
Compare
Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com>
Now there is a `user_specified_block_size` variable in CacheConfig. Probably it was introduced to figure out whether the user changed the block size or not. In vllm-spyre platform.py we're not technically the user, but only 64 is valid on Spyre anyway and for some reason, setting the block_size directly no longer workes because it's overwritten with the default of 16. Signed-off-by: Max de Bayser <maxdebayser@gmail.com>
5 tasks
Signed-off-by: Max de Bayser <maxdebayser@gmail.com>
Signed-off-by: Max de Bayser <maxdebayser@gmail.com>
Collaborator
|
bot:test |
Collaborator
|
bot:test |
In 2.10, emtpy_cache() is available but throws an error because in vllm-spyre we don´t allocate any accelerator. Since in spyre-next we will do so, I think it's better to add a check before calling empty_cache() instead of just replacing the whole thing by a noop Signed-off-by: Max de Bayser <mbayser@br.ibm.com>
Collaborator
|
bot:test |
maxdebayser
requested review from
joerunde,
nikolaospapandreou,
prashantgupta24,
sducouedic,
tdoublep and
yannicks1
as code owners
Collaborator
|
@rafvasq , @tjohnson31415 , except for the readthedocs check, all other tests are passing. Since this PR doesn't touch the docs, I think it's not a blocker. |
Collaborator
Author
|
Thanks @maxdebayser, yes the unrelated doc failure is fixed in #860. |
github-actions
Bot
added
the
ready
Signed-off-by: Max de Bayser <mbayser@br.ibm.com>
Collaborator
|
bot:test |
1 similar comment
Collaborator
|
bot:test |
Signed-off-by: Max de Bayser <mbayser@br.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
2.7.1--swap-spaceparam ([V0 Deprecation] Remove unused swap_space parameter vllm-project/vllm#36216)cache_config.user_specified_block_size = Trueto avoid block size overrides.Related Issues
Checklist
bash format.sh)Signed-off-by:line (DCO compliance)