Skip to content

chore (1.x): support vllm 0.18.0 without backwards compat#861

Merged
tjohnson31415 merged 7 commits intotorch-spyre:stable/1.xfrom
tjohnson31415:1.x-upgrade-vllm
Mar 26, 2026
Merged

chore (1.x): support vllm 0.18.0 without backwards compat#861
tjohnson31415 merged 7 commits intotorch-spyre:stable/1.xfrom
tjohnson31415:1.x-upgrade-vllm

Conversation

@tjohnson31415
Copy link
Copy Markdown
Collaborator

@tjohnson31415 tjohnson31415 commented Mar 24, 2026

Description

We want to make another release on the 1.x line and need to use the latest vLLM. We are allowing this change to drop support for older vLLM versions. vLLM supported range will now have 0.17.0 as a lower bound.

Related Issues

Test Plan

Must pass all standard CI tests.

Checklist

  • I have read the contributing guidelines
  • My code follows the project's code style (run bash format.sh)
  • I have added tests for my changes (if applicable)
  • I have updated the documentation (if applicable)
  • My commits include a Signed-off-by: line (DCO compliance)

@github-actions
Copy link
Copy Markdown

👋 Hi! Thank you for contributing to vLLM support on Spyre.
Just a reminder: Make sure that your code passes all the linting checks, otherwise your PR won't be able to be merged. To do so, run ./format.sh.
Now you are good to go 🚀.

We also recommend installing prek and configuring it to check your code before every local commit.

Signed-off-by: Travis Johnson <tsjohnso@us.ibm.com>
Signed-off-by: Travis Johnson <tsjohnso@us.ibm.com>
Signed-off-by: Travis Johnson <tsjohnso@us.ibm.com>
Signed-off-by: Travis Johnson <tsjohnso@us.ibm.com>
Signed-off-by: Travis Johnson <tsjohnso@us.ibm.com>
Copy link
Copy Markdown
Collaborator

@maxdebayser maxdebayser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Travis Johnson <tsjohnso@us.ibm.com>
Signed-off-by: Travis Johnson <tsjohnso@us.ibm.com>
@tjohnson31415
Copy link
Copy Markdown
Collaborator Author

Had a job fail with an client timeout / broken connection a couple times, but now it seems to have passed. I also reproduced it locally, but the was unable to reproduce it after a few more tries. So we may have a little bit of flakiness 🤔

@tjohnson31415
Copy link
Copy Markdown
Collaborator Author

bot:test
MARKERS="spyre and not quantized"

@tjohnson31415
Copy link
Copy Markdown
Collaborator Author

bot:test
MARKERS="spyre and prefix_caching and not quantized"

@tjohnson31415
Copy link
Copy Markdown
Collaborator Author

bot:test
MARKERS="spyre and cb and not quantized"

1 similar comment
@tjohnson31415
Copy link
Copy Markdown
Collaborator Author

bot:test
MARKERS="spyre and cb and not quantized"

@tjohnson31415
Copy link
Copy Markdown
Collaborator Author

Remaining spyre-ci failures have been confirmed to be unrelated to this PR's changes.

@tjohnson31415 tjohnson31415 merged commit 7fd2f73 into torch-spyre:stable/1.x Mar 26, 2026
26 of 29 checks passed
@tjohnson31415 tjohnson31415 deleted the 1.x-upgrade-vllm branch March 26, 2026 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants