[GE-630] Adjust deploy-storybook for Frontier usage #87
Conversation
🦋 Changeset detectedLatest commit: d564a6e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Greetings from FX team, @stefanteixeira 👋 Thank you so much for contributing 🙇 We have got high priority ticket generated on our Kanban board so we will do our best to make your experience supreme! What's next? We will collaborate using this workflow. For you this practically means making sure DONE criteria is met and responding promptly to code review comments 😉 🙏 please, help us improve, rate your contributing experience after merge |
stefanteixeira
force-pushed
the
use-deploy-storybook-action-frontier
branch
from
cca35db to
e75e70f
Compare
There was a problem hiding this comment.
Oh, almost forgot - need to add a changeset:
run yarn changeset locally
or click here
|
@OndrejTuma my bad! It's added now 👍 |
GE-630
Description
Extending
deploy-storybookaction to support deployments for frontier-pub project, from the Growth Squad. To optimize the process, I've added a couple of options to enable using an existing Storybook package or an existing Docker image, avoiding the need of building the package/image twice. Also, an option to be able to set a custom folder name on Jenkins, since all of our jobs are on aFrontierfolder, which does not match the repository name.Finally, fixing
set-outputwarnings fromdeploy-storybookandyarn-installactions, since that will be deprecated soonDevelopment checks
PR commands
List of available commands:
@toptal-anvil ping reviewers- Ping FX team for review