fix: [FX-2626] set up danger env variable for self-hosted runners #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6a7cb09 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@toptal-anvil ping reviewers |
serbantarmure
approved these changes
Feb 27, 2023
OleksandrNechai
approved these changes
Feb 27, 2023
TomasSlama
approved these changes
Feb 27, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FX-2626
Description
Self-hosted runners may override
GITHUB_URLvariable, so requests may be performed incorectly.This code explains how danger defined API URL: https://github.com/danger/danger-js/blob/main/source/platforms/github/GitHubAPI.ts#LL452C96-L452C118
How to test
Development checks
PR commands
List of available commands:
@toptal-anvil ping reviewers- Ping FX team for review