Add support for direct_import parameter to skip objects reloading #753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalthon
force-pushed
the
import_objects
branch
2 times, most recently
from
53c647e
to
6af1cba
Compare
rabotyaga
suggested changes
Feb 8, 2021
dalthon
force-pushed
the
import_objects
branch
from
6af1cba
to
1ac3699
Compare
dalthon
force-pushed
the
import_objects
branch
from
1ac3699
to
2c3a8a2
Compare
rabotyaga
reviewed
Feb 8, 2021
rabotyaga
reviewed
Feb 8, 2021
|
@rabotyaga I was checking values at < consistency
> direct_import
< pipeline
< raw_import
< refresh
< replication
> parallel
> suffix
> update_failover
> update_fieldsDo you think that the same applies for |
|
@dalthon chewy/lib/chewy/type/import/routine.rb Lines 25 to 30 in 7efd2e3 raw_import is passed to orm adapter.Let's leave missing import keys like update_failover & update_fields since nobody complains.
And let's add CHANGELOG entry. |
|
@rabotyaga changelog added |
rabotyaga
changed the title
rabotyaga
force-pushed
the
import_objects
branch
from
9bc77d1
to
235d8fc
Compare
rabotyaga
approved these changes
Feb 10, 2021
…pe on import * Skimpier direct_import * Fix linter error in orm.rb * Add spec and fixed an issue related to ids * Update lib/chewy/type/import.rb * Allow direct_import as default import options * Update CHANGELOG.md * Add a note about default `direct_import` value * Improve error messages in db_queries helpers Co-authored-by: Ivan Rabotyaga <[email protected]> Co-authored-by: Dalton Pinto <[email protected]>
dalthon
force-pushed
the
import_objects
branch
from
ca44e94
to
869ae88
Compare
This was referenced Mar 8, 2021
This was referenced Mar 15, 2021
cyucelen
pushed a commit
to cyucelen/chewy
that referenced
this pull request
Jan 28, 2023
…pe on import (toptal#753) * Skimpier direct_import * Fix linter error in orm.rb * Add spec and fixed an issue related to ids * Update lib/chewy/type/import.rb * Allow direct_import as default import options * Update CHANGELOG.md * Add a note about default `direct_import` value * Improve error messages in db_queries helpers Co-authored-by: Tikhon Botchkarev <[email protected]> Co-authored-by: Ivan Rabotyaga <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a rebase of #637 with added spec and a small fix regarding id types