-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for direct_import parameter to skip loading default scope on import #637
Conversation
@pyromaniac Does this implementation work for you? |
@TikiTDO I'm no maintainer but I see some import specs for active_record here: |
@abraham-chan I've moved quite a far from this section of my project, and I've got work queued up for months ahead. If you wish to take over, then feel free to fork this branch, otherwise I might at best have time to look at this in a few months |
I was amazed to realize that if you call Can anyone (maybe @pyromaniac ?) explain why it re-queries for objects that are already in memory prior to sending to ES? Is there any workarounds, or would this branch be needed in order to import AR objects that are already in memory without reloading them from the DB? |
Can one of the admins verify this patch? |
Well, I did it because it looks more reliable. I can merge this option as soon as some specs will be added. |
Looking at this I vaguely remember that this had something to do with a manual importer, but I can't actually recall the nature of the problem anymore. @dtpowl you referenced this recently, is this something you could take over, or failing that could you remind me what issue this was trying to solve? |
Proof of Concept to get around issue outlined in #636.
Currently there's no tests, as I wasn't sure how the spec files were structured for this project. I can add the specs if someone could point me to an example where I could exercise the functionality of importing objects with extra includes.