Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dockerfile: print bats version #178

Closed
wants to merge 1 commit into from

Conversation

crazy-max
Copy link
Collaborator

follow-up #176 (comment)

Output bats version in our Dockerfile as I suspect an old version of bats on Ubuntu 20.04 does not support setup_file in:

xx/src/test-go.bats

Lines 15 to 17 in fc22666

setup_file() {
ensureGo
}

And therefore go is not installed.

Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
@crazy-max
Copy link
Collaborator Author

On Ubuntu 20.04 it installs bats 1.2.0-dev: https://github.com/tonistiigi/xx/actions/runs/12237165029/job/34132286873#step:5:802

#46 11.60 Bats 1.2.0-dev

Which does not support setup_file. This feature is available since 1.2.1: bats-core/bats-core#246 / bats-core/bats-core@10b0daf

@crazy-max crazy-max requested a review from tonistiigi December 9, 2024 14:07
@crazy-max crazy-max marked this pull request as draft December 9, 2024 15:41
@crazy-max
Copy link
Collaborator Author

superseded by #180

@crazy-max crazy-max closed this Dec 9, 2024
@crazy-max crazy-max deleted the print-bats-version branch December 9, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant