Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for toml 1.0 #58

Closed
3 tasks done
Tracked by #133
ordian opened this issue Apr 25, 2019 · 5 comments
Closed
3 tasks done
Tracked by #133

add support for toml 1.0 #58

ordian opened this issue Apr 25, 2019 · 5 comments
Milestone

Comments

@ordian
Copy link
Member

ordian commented Apr 25, 2019

@joseluis
Copy link

joseluis commented Feb 5, 2021

Toml 1.0 has finally been released, and here is the updated spec (link in OP is dead):

https://github.com/toml-lang/toml/blob/master/toml.md

@ordian
Copy link
Member Author

ordian commented Feb 5, 2021

The spec is available here: https://toml.io/en/v1.0.0

One of the major changes is adding support for dotted keys. There is a WIP PR for that #73, but it hasn't been moving forward recently.

@epage
Copy link
Member

epage commented Aug 5, 2021

Splitting out of rust-lang/cargo#5586.

Just wanted to double check before you leave that you are good with continuing forward with updating the parser as-is or if the lexer re-work needs to be done and done first. If so, I'll take up #73 and other conformance work for 1.0.

@ordian
Copy link
Member Author

ordian commented Aug 5, 2021

I think reworking the lexer #57 (if there is a consensus it needs to be done) and comformance to 1.0 are two independent tasks.

@epage epage changed the title add support for toml 0.5 add support for toml 1.0 Aug 26, 2021
@epage
Copy link
Member

epage commented Sep 3, 2021

I'm going to declare us implementing 1.0 but with an open bug (#128)

@epage epage closed this as completed Sep 3, 2021
epage added a commit to epage/toml_edit that referenced this issue Sep 29, 2021
Required munging the grammar so `combine` could understand, but we got
it!

Fixes toml-rs#58
epage added a commit that referenced this issue Sep 29, 2021
Required munging the grammar so `combine` could understand, but we got
it!

Fixes #58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants