-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make toml_edit
viable for cargo
#133
Comments
@ordian as I go through this, how much design review or PR review involvement do you want? So far I've been going ahead and merging-and-moving on for small things like comment fixes and for everything else I've been floating the design and PR by you. Just wondering if what you feel you need in case there is wiggle room to expedite cycle time a bit (since a lot of changes have risk of conflict heavy, I've been task switching rather than continuing on) |
I added you as a collaborator on this repo, so you can merge stuff you find not controversial. I'm happy to provide feedback on the design of API for dotted keys as it seems like a big and not an easy one. But other than that feel free to merge as if this repo was cargo-release :) |
Thanks for the clarification; I didn't want to overstep any boundaries. |
We now have a tag for this instead: https://github.com/ordian/toml_edit/labels/cargo |
Cargo.toml
files #130chrono
from the public API #131toml-rs
API on top oftoml_edit
#129toml-rs
#132We might also need
toml_edit
doesn't properly handle quotes in strings #128easy::to_string_pretty
doesn't produce pretty results #192serde
types as values #205The text was updated successfully, but these errors were encountered: