Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make toml_edit viable for cargo #133

Closed
5 tasks done
epage opened this issue Aug 26, 2021 · 4 comments
Closed
5 tasks done

Make toml_edit viable for cargo #133

epage opened this issue Aug 26, 2021 · 4 comments
Labels
C-enhancement Category: Raise on the bar on expectations

Comments

@epage epage added the C-enhancement Category: Raise on the bar on expectations label Aug 26, 2021
@epage
Copy link
Member Author

epage commented Aug 26, 2021

@ordian as I go through this, how much design review or PR review involvement do you want? So far I've been going ahead and merging-and-moving on for small things like comment fixes and for everything else I've been floating the design and PR by you. Just wondering if what you feel you need in case there is wiggle room to expedite cycle time a bit (since a lot of changes have risk of conflict heavy, I've been task switching rather than continuing on)

@ordian
Copy link
Member

ordian commented Aug 26, 2021

I added you as a collaborator on this repo, so you can merge stuff you find not controversial. I'm happy to provide feedback on the design of API for dotted keys as it seems like a big and not an easy one. But other than that feel free to merge as if this repo was cargo-release :)

@epage
Copy link
Member Author

epage commented Aug 26, 2021

Thanks for the clarification; I didn't want to overstep any boundaries.

@epage
Copy link
Member Author

epage commented Nov 16, 2021

We now have a tag for this instead: https://github.com/ordian/toml_edit/labels/cargo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: Raise on the bar on expectations
Projects
None yet
Development

No branches or pull requests

2 participants