Support parsing all Cargo.toml files

[epage]

This is a pre-req to replacing toml-rs in cargo.

To do this, we might need a feature flag for deviating from the toml standard.

This will require comparing parse results between both parsers across all of crates.io. My assumption is we'd have a command that pulls in both crates and uses the toml_test encoding to compare the resylts

• toml-rs API on top of toml_edit #129
• Create toml_test encoding for toml-rs
• Create test utility that compares toml-rs against toml-rs API on top of toml_edit #129
• Fix issues as needed, using a feature flag when deviating from TOML spec

[epage]

In crate-ci/cargo-release#326 (comment), kornelski gave some pointers

Thanks.

I get Cargo.toml the hard way, by downloading the crate file:

https://gitlab.com/crates.rs/crates.rs/-/blob/main/crates_io_client/src/lib_crates_io_client.rs#L77

and extracting it:

https://gitlab.com/crates.rs/crates.rs/-/blob/main/tarball/src/lib.rs

If you want to test the broken ones, look for Cargo.toml.orig.

[epage]

• https://github.com/alexcrichton/toml-rs/blob/master/test-suite/tests/backcompat.rs
• https://github.com/rust-lang/cargo/blob/216f915c46b8ada2323423d049314ba18247ef95/src/cargo/util/toml/mod.rs#L160

The warning says support for this is going to be removed. I wonder when that can happen

The lack of newline could be handled through a regex. Unfortunately, the split table can't

[epage]

rust-lang/cargo#9932 removes the compatibility hacks from Cargo.

[epage]

This is open ended enough, I'm going to go ahead and close it for what has been done.

[epage]

nm, I do want to track this here

[epage]

ehuss did this for us: https://rust-lang.zulipchat.com/#narrow/stream/246057-t-cargo/topic/toml_edit.20testing/near/263954437

@_Eric Huss|120518 said:

@Ed Page I forgot to tell you, I tested toml_edit against every TOML file ever published > to crates.io against the toml crate, and the only issues I found were the two that I opened.