-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Snap to core22 #96
Conversation
Successfully deployed to the Snap store: https://snapcraft.io/emote-sonjoonho. Will remove when/if the primary Snap is updated. |
Hi @sonjoonho - thanks so much for working this out. I had thought that I had already responded, but it looks like I didn't! We have an ongoing migration to flatpak in the works, which is on the Given the fact that that branch has diverged quite a bit, it looks like we won't actually directly merge this PR but instead are reworking it into |
When I build a new snap package with this branch locally and try and run it, the app looks like this: Console output for running it:
This is on Debian 12. |
The currently published emote works fine by the way. |
These changes here seem to fix that problem - vemonet#4. |
This has been merged via the flatpak branch and is now pushed to the stable snap channel. Thank you for your contribution 💪🏼. |
Ah cool! I'm actually still encountering the |
This happens with the published 4.0.0 Snap too. I'll look into this at some point this week. |
It works fine locally on my computer. I will double check it on a couple more machines. |
It works fine when I log out and log in again. I guess some environment variables need setting on log in or something. I'll look for a workaround. |
Oh sorry I was trying to run from the command line, opens normally when I open it from the desktop file. Sorry for the red herring; will split off any other bugs I find into separate issues. |
Migrates the base Snap to core22. core22 is bundled with Python 3.10 so I've had to update various dependencies. There's also quite a few issues with the Gnome extension so I've had to implement a couple of workaround (marked by comments). I've also removed a number of package dependencies because I couldn't figure out what they're for, but lmk if they are required (also halves the size of the snap).
Related to #48 and #63, hopefully unblocks new releases.
As a side note, we should be able to stop bundling the font file and instead use the user's system font instead. This would fix/alleviate issues like #83, #86, #71, and #67.
Due to https://forum.snapcraft.io/t/core22-gnome-extension-and-broken-symlinks/32900 it's necessary to use a pre-release version of Snapcraft to deploy the snap.