Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put back Snap packaging #100

Merged
merged 13 commits into from
Jun 19, 2023
Merged

Conversation

vemonet
Copy link
Collaborator

@vemonet vemonet commented Jun 19, 2023

PR built on the changes made by #99 @tom-james-watson

It put back snap packaging by pulling the changes made by @sonjoonho in #96 and fixing the conflicts

core22 was using python 3.10, but with flatpak we use 3.11, so we will need to check if snap still works with 3.11

I don't have snap installed though, so could not try it out, if someone can that would be really nice 😇

@tom-james-watson
Copy link
Owner

Couple of small fixes: vemonet#3

@vemonet
Copy link
Collaborator Author

vemonet commented Jun 19, 2023

I guess we will also want to merge the flatpak branch into master before sending the PR to flathub

@tom-james-watson
Copy link
Owner

Yeah. I'm still testing the snap side of things. I've reinstalled my OS recently so having to set a few things up for first time again.

@vemonet
Copy link
Collaborator Author

vemonet commented Jun 19, 2023

Ok, I started a branch to be merged to the flathub repo here: https://github.com/vemonet/flathub/tree/com.tomjwatson.Emote

vemonet and others added 2 commits June 19, 2023 14:32
flatpak run org.freedesktop.appstream-glib validate flatpak/com.tomjwatson.Emote.metainfo.xml
flatpak/com.tomjwatson.Emote.metainfo.xml: FAILED:
• style-invalid         : Content before <ul> is too short [13], at least 20 characters required command
Also stops bundling and loading custom font - this seems to cause
problems and doesn't actually seem needed right now.
@tom-james-watson
Copy link
Owner

This properly fixes the snap integration: vemonet#4

@tom-james-watson
Copy link
Owner

Going to merge this now. Feel free to go ahead and make the PR for flathub and just tag me on it - thanks!!

@tom-james-watson tom-james-watson merged commit 2db9f32 into tom-james-watson:flatpak Jun 19, 2023
@vemonet
Copy link
Collaborator Author

vemonet commented Jun 19, 2023

Thanks, I installed snap and am trying to run the snap install, but it takes forever and does not provide useful feedbacks

I also experimented with setting up a github action to test building the flatpak and snap packages: https://github.com/vemonet/Emote/blob/flatpak/.github/workflows/build.yml
Which might help maintaining the project in the future (and maybe setup a release workflow instead of doing it locally?)

It will try to build it, but I am not sure how to test if the package is properly installed (it success for the 2 currently): https://github.com/vemonet/Emote/actions/runs/5313146037/jobs/9618633302

@tom-james-watson
Copy link
Owner

Ah wow that would be really nice! 🎉

I was able to install the snap artifact fine with sudo snap install ./emote_3.1.0_amd64.snap --dangerous. The first time I ever did this it did take a weirdly long time, like several minutes. Now it does it in a few seconds. Just snap things I guess 🤷‍♂️.

It does fail to run, but I think that branch didn't have the latest snap fixes in it, because it looks like it's still trying to load fonts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants