-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Put back Snap packaging #100
Put back Snap packaging #100
Conversation
…emove duplicate desktop file from the flatpak folder
…of 3.10 for core22). And update requirements files
Couple of small fixes: vemonet#3 |
snap fixes / readme
I guess we will also want to merge the |
Yeah. I'm still testing the snap side of things. I've reinstalled my OS recently so having to set a few things up for first time again. |
Ok, I started a branch to be merged to the flathub repo here: https://github.com/vemonet/flathub/tree/com.tomjwatson.Emote |
flatpak run org.freedesktop.appstream-glib validate flatpak/com.tomjwatson.Emote.metainfo.xml flatpak/com.tomjwatson.Emote.metainfo.xml: FAILED: • style-invalid : Content before <ul> is too short [13], at least 20 characters required command
Also stops bundling and loading custom font - this seems to cause problems and doesn't actually seem needed right now.
This properly fixes the snap integration: vemonet#4 |
restore removed snap code
Going to merge this now. Feel free to go ahead and make the PR for flathub and just tag me on it - thanks!! |
Thanks, I installed snap and am trying to run the snap install, but it takes forever and does not provide useful feedbacks I also experimented with setting up a github action to test building the flatpak and snap packages: https://github.com/vemonet/Emote/blob/flatpak/.github/workflows/build.yml It will try to build it, but I am not sure how to test if the package is properly installed (it success for the 2 currently): https://github.com/vemonet/Emote/actions/runs/5313146037/jobs/9618633302 |
Ah wow that would be really nice! 🎉 I was able to install the snap artifact fine with It does fail to run, but I think that branch didn't have the latest snap fixes in it, because it looks like it's still trying to load fonts. |
PR built on the changes made by #99 @tom-james-watson
It put back snap packaging by pulling the changes made by @sonjoonho in #96 and fixing the conflicts
core22 was using python 3.10, but with flatpak we use 3.11, so we will need to check if snap still works with 3.11
I don't have snap installed though, so could not try it out, if someone can that would be really nice 😇