subscriber: don't gate with_ansi() on the "ansi" feature
#3020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Github actions aren't starting. I'm guessing that's because this PR is more than 30 days old. I'll try a no-op push to the branch to see if it gets things moving. |
auto-merge was automatically disabled
July 31, 2024 00:52
Head branch was pushed to by a user without write access
eric-seppanen
force-pushed
the
fix_ansi_cfg
branch
from
be13955 to
8544143
Compare
|
Ah, now it's stopped by "This workflow requires approval from a maintainer." @hawkw can you help? Also, auto-merge was disabled because I pushed to the branch. (No changes were made.) |
|
Ping? @hawkw you approved this PR but CI won't run until a maintainer intervenes. |
|
My bad! Running the workflow now. |
|
Clippy lint warnings appear to be unrelated; CI runs latest stable and at least some of the lints are things I recognize as being new in 1.80. |
eric-seppanen
force-pushed
the
fix_ansi_cfg
branch
from
8544143 to
14e7af5
Compare
|
Rebased on the latest |
|
CI is blocked on "This workflow requires approval from a maintainer". Could someone help move it along? As far as I can tell, this is ready to merge. It's a very simple fix and received approval months ago. |
|
Could someone please approve the CI workflow for this PR? As seen earlier, if it gets more than 30 days old then CI won't be able to run. |
13 tasks
eric-seppanen
force-pushed
the
fix_ansi_cfg
branch
from
14e7af5 to
8691dfe
Compare
|
Rebased again on the latest v0.1.x branch. There were no conflicts. This PR still needs manual approval for CI to run. |
hds
added a commit
that referenced
this pull request
Nov 28, 2024
# 0.3.19 (November 29, 2024) [ [crates.io][crate-0.3.19] ] | [ [docs.rs][docs-0.3.19] ] This release updates the `tracing` dependency to [v0.1.41][tracing-0.1.41] and the `tracing-serde` dependency to [v0.2.0][tracing-serde-0.2.0]. ### Added - Add `set_span_events` to `fmt::Subscriber` ([#2962]) - **tracing**: Allow `&[u8]` to be recorded as event/span field (#2954) ### Changed - Set `log` max level when reloading ([#1270) - Bump MSRV to 1.63 ([#2793]) - Use const `thread_local`s when possible ([#2838]) - Don't gate `with_ansi()` on the "ansi" feature ([#3020]) - Updated tracing-serde to 0.2.0 ([#3160]) [#1270]: #1270 [#2793]: #2793 [#2838]: #2838 [#2962]: #2962 [#3020]: #3020 [#3160]: #3160 [tracing-0.1.41]: https://github.com/tokio-rs/tracing/releases/tag/tracing-0.1.41 [tracing-serde-0.2.0]: https://github.com/tokio-rs/tracing/releases/tag/tracing-serde-0.2.0 [docs-0.3.19]: https://docs.rs/tracing-subscriber/0.3.19/tracing_subscriber/ [crate-0.3.19]: https://crates.io/crates/tracing-subscriber/0.3.19
hds
added a commit
that referenced
this pull request
Nov 28, 2024
# 0.3.19 (November 29, 2024) [ [crates.io][crate-0.3.19] ] | [ [docs.rs][docs-0.3.19] ] This release updates the `tracing` dependency to [v0.1.41][tracing-0.1.41] and the `tracing-serde` dependency to [v0.2.0][tracing-serde-0.2.0]. ### Added - Add `set_span_events` to `fmt::Subscriber` ([#2962]) - **tracing**: Allow `&[u8]` to be recorded as event/span field ([#2954]) ### Changed - Set `log` max level when reloading ([#1270]) - Bump MSRV to 1.63 ([#2793]) - Use const `thread_local`s when possible ([#2838]) - Don't gate `with_ansi()` on the "ansi" feature ([#3020]) - Updated tracing-serde to 0.2.0 ([#3160]) [#1270]: #1270 [#2793]: #2793 [#2838]: #2838 [#2962]: #2962 [#3020]: #3020 [#3160]: #3160 [tracing-0.1.41]: https://github.com/tokio-rs/tracing/releases/tag/tracing-0.1.41 [tracing-serde-0.2.0]: https://github.com/tokio-rs/tracing/releases/tag/tracing-serde-0.2.0 [docs-0.3.19]: https://docs.rs/tracing-subscriber/0.3.19/tracing_subscriber/ [crate-0.3.19]: https://crates.io/crates/tracing-subscriber/0.3.19
hds
added a commit
that referenced
this pull request
Nov 28, 2024
# 0.3.19 (November 28, 2024) [ [crates.io][crate-0.3.19] ] | [ [docs.rs][docs-0.3.19] ] This release updates the `tracing` dependency to [v0.1.41][tracing-0.1.41] and the `tracing-serde` dependency to [v0.2.0][tracing-serde-0.2.0]. ### Added - Add `set_span_events` to `fmt::Subscriber` ([#2962]) - **tracing**: Allow `&[u8]` to be recorded as event/span field ([#2954]) ### Changed - Set `log` max level when reloading ([#1270]) - Bump MSRV to 1.63 ([#2793]) - Use const `thread_local`s when possible ([#2838]) - Don't gate `with_ansi()` on the "ansi" feature ([#3020]) - Updated tracing-serde to 0.2.0 ([#3160]) [#1270]: #1270 [#2793]: #2793 [#2838]: #2838 [#2954]: #2954 [#2962]: #2962 [#3020]: #3020 [#3160]: #3160 [tracing-0.1.41]: https://github.com/tokio-rs/tracing/releases/tag/tracing-0.1.41 [tracing-serde-0.2.0]: https://github.com/tokio-rs/tracing/releases/tag/tracing-serde-0.2.0 [docs-0.3.19]: https://docs.rs/tracing-subscriber/0.3.19/tracing_subscriber/ [crate-0.3.19]: https://crates.io/crates/tracing-subscriber/0.3.19
hds
added a commit
that referenced
this pull request
Nov 29, 2024
# 0.3.19 (November 29, 2024) [ [crates.io][crate-0.3.19] ] | [ [docs.rs][docs-0.3.19] ] This release updates the `tracing` dependency to [v0.1.41][tracing-0.1.41] and the `tracing-serde` dependency to [v0.2.0][tracing-serde-0.2.0]. ### Added - Add `set_span_events` to `fmt::Subscriber` ([#2962]) - **tracing**: Allow `&[u8]` to be recorded as event/span field ([#2954]) ### Changed - Set `log` max level when reloading ([#1270]) - Bump MSRV to 1.63 ([#2793]) - Use const `thread_local`s when possible ([#2838]) - Don't gate `with_ansi()` on the "ansi" feature ([#3020]) - Updated tracing-serde to 0.2.0 ([#3160]) [#1270]: #1270 [#2793]: #2793 [#2838]: #2838 [#2954]: #2954 [#2962]: #2962 [#3020]: #3020 [#3160]: #3160 [tracing-0.1.41]: https://github.com/tokio-rs/tracing/releases/tag/tracing-0.1.41 [tracing-serde-0.2.0]: https://github.com/tokio-rs/tracing/releases/tag/tracing-serde-0.2.0 [docs-0.3.19]: https://docs.rs/tracing-subscriber/0.3.19/tracing_subscriber/ [crate-0.3.19]: https://crates.io/crates/tracing-subscriber/0.3.19
hds
added a commit
that referenced
this pull request
Nov 29, 2024
# 0.3.19 (November 29, 2024) [ [crates.io][crate-0.3.19] ] | [ [docs.rs][docs-0.3.19] ] This release updates the `tracing` dependency to [v0.1.41][tracing-0.1.41] and the `tracing-serde` dependency to [v0.2.0][tracing-serde-0.2.0]. ### Added - Add `set_span_events` to `fmt::Subscriber` ([#2962]) - **tracing**: Allow `&[u8]` to be recorded as event/span field ([#2954]) ### Changed - Set `log` max level when reloading ([#1270]) - Bump MSRV to 1.63 ([#2793]) - Use const `thread_local`s when possible ([#2838]) - Don't gate `with_ansi()` on the "ansi" feature ([#3020]) - Updated tracing-serde to 0.2.0 ([#3160]) [#1270]: #1270 [#2793]: #2793 [#2838]: #2838 [#2954]: #2954 [#2962]: #2962 [#3020]: #3020 [#3160]: #3160 [tracing-0.1.41]: https://github.com/tokio-rs/tracing/releases/tag/tracing-0.1.41 [tracing-serde-0.2.0]: https://github.com/tokio-rs/tracing/releases/tag/tracing-serde-0.2.0 [docs-0.3.19]: https://docs.rs/tracing-subscriber/0.3.19/tracing_subscriber/ [crate-0.3.19]: https://crates.io/crates/tracing-subscriber/0.3.19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit 1cb523b removed this cfg gate on master. However, when the change was backported in 049ad73 the docs were updated but the
cfgchange was omitted. Some more detail and links are in issue #2996.This made the docs misleading, since they say "This method itself is still available without the feature flag."
Fixes #2996.