subscriber: add set_span_events to fmt::Subscriber
#2962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawkw
approved these changes
May 3, 2024
20 tasks
hds
pushed a commit
that referenced
this pull request
Nov 21, 2024
hds
pushed a commit
that referenced
this pull request
Nov 22, 2024
hds
added a commit
that referenced
this pull request
Nov 28, 2024
# 0.3.19 (November 29, 2024) [ [crates.io][crate-0.3.19] ] | [ [docs.rs][docs-0.3.19] ] This release updates the `tracing` dependency to [v0.1.41][tracing-0.1.41] and the `tracing-serde` dependency to [v0.2.0][tracing-serde-0.2.0]. ### Added - Add `set_span_events` to `fmt::Subscriber` ([#2962]) - **tracing**: Allow `&[u8]` to be recorded as event/span field (#2954) ### Changed - Set `log` max level when reloading ([#1270) - Bump MSRV to 1.63 ([#2793]) - Use const `thread_local`s when possible ([#2838]) - Don't gate `with_ansi()` on the "ansi" feature ([#3020]) - Updated tracing-serde to 0.2.0 ([#3160]) [#1270]: #1270 [#2793]: #2793 [#2838]: #2838 [#2962]: #2962 [#3020]: #3020 [#3160]: #3160 [tracing-0.1.41]: https://github.com/tokio-rs/tracing/releases/tag/tracing-0.1.41 [tracing-serde-0.2.0]: https://github.com/tokio-rs/tracing/releases/tag/tracing-serde-0.2.0 [docs-0.3.19]: https://docs.rs/tracing-subscriber/0.3.19/tracing_subscriber/ [crate-0.3.19]: https://crates.io/crates/tracing-subscriber/0.3.19
hds
added a commit
that referenced
this pull request
Nov 28, 2024
# 0.3.19 (November 29, 2024) [ [crates.io][crate-0.3.19] ] | [ [docs.rs][docs-0.3.19] ] This release updates the `tracing` dependency to [v0.1.41][tracing-0.1.41] and the `tracing-serde` dependency to [v0.2.0][tracing-serde-0.2.0]. ### Added - Add `set_span_events` to `fmt::Subscriber` ([#2962]) - **tracing**: Allow `&[u8]` to be recorded as event/span field ([#2954]) ### Changed - Set `log` max level when reloading ([#1270]) - Bump MSRV to 1.63 ([#2793]) - Use const `thread_local`s when possible ([#2838]) - Don't gate `with_ansi()` on the "ansi" feature ([#3020]) - Updated tracing-serde to 0.2.0 ([#3160]) [#1270]: #1270 [#2793]: #2793 [#2838]: #2838 [#2962]: #2962 [#3020]: #3020 [#3160]: #3160 [tracing-0.1.41]: https://github.com/tokio-rs/tracing/releases/tag/tracing-0.1.41 [tracing-serde-0.2.0]: https://github.com/tokio-rs/tracing/releases/tag/tracing-serde-0.2.0 [docs-0.3.19]: https://docs.rs/tracing-subscriber/0.3.19/tracing_subscriber/ [crate-0.3.19]: https://crates.io/crates/tracing-subscriber/0.3.19
hds
added a commit
that referenced
this pull request
Nov 28, 2024
# 0.3.19 (November 28, 2024) [ [crates.io][crate-0.3.19] ] | [ [docs.rs][docs-0.3.19] ] This release updates the `tracing` dependency to [v0.1.41][tracing-0.1.41] and the `tracing-serde` dependency to [v0.2.0][tracing-serde-0.2.0]. ### Added - Add `set_span_events` to `fmt::Subscriber` ([#2962]) - **tracing**: Allow `&[u8]` to be recorded as event/span field ([#2954]) ### Changed - Set `log` max level when reloading ([#1270]) - Bump MSRV to 1.63 ([#2793]) - Use const `thread_local`s when possible ([#2838]) - Don't gate `with_ansi()` on the "ansi" feature ([#3020]) - Updated tracing-serde to 0.2.0 ([#3160]) [#1270]: #1270 [#2793]: #2793 [#2838]: #2838 [#2954]: #2954 [#2962]: #2962 [#3020]: #3020 [#3160]: #3160 [tracing-0.1.41]: https://github.com/tokio-rs/tracing/releases/tag/tracing-0.1.41 [tracing-serde-0.2.0]: https://github.com/tokio-rs/tracing/releases/tag/tracing-serde-0.2.0 [docs-0.3.19]: https://docs.rs/tracing-subscriber/0.3.19/tracing_subscriber/ [crate-0.3.19]: https://crates.io/crates/tracing-subscriber/0.3.19
hds
added a commit
that referenced
this pull request
Nov 29, 2024
# 0.3.19 (November 29, 2024) [ [crates.io][crate-0.3.19] ] | [ [docs.rs][docs-0.3.19] ] This release updates the `tracing` dependency to [v0.1.41][tracing-0.1.41] and the `tracing-serde` dependency to [v0.2.0][tracing-serde-0.2.0]. ### Added - Add `set_span_events` to `fmt::Subscriber` ([#2962]) - **tracing**: Allow `&[u8]` to be recorded as event/span field ([#2954]) ### Changed - Set `log` max level when reloading ([#1270]) - Bump MSRV to 1.63 ([#2793]) - Use const `thread_local`s when possible ([#2838]) - Don't gate `with_ansi()` on the "ansi" feature ([#3020]) - Updated tracing-serde to 0.2.0 ([#3160]) [#1270]: #1270 [#2793]: #2793 [#2838]: #2838 [#2954]: #2954 [#2962]: #2962 [#3020]: #3020 [#3160]: #3160 [tracing-0.1.41]: https://github.com/tokio-rs/tracing/releases/tag/tracing-0.1.41 [tracing-serde-0.2.0]: https://github.com/tokio-rs/tracing/releases/tag/tracing-serde-0.2.0 [docs-0.3.19]: https://docs.rs/tracing-subscriber/0.3.19/tracing_subscriber/ [crate-0.3.19]: https://crates.io/crates/tracing-subscriber/0.3.19
hds
added a commit
that referenced
this pull request
Nov 29, 2024
# 0.3.19 (November 29, 2024) [ [crates.io][crate-0.3.19] ] | [ [docs.rs][docs-0.3.19] ] This release updates the `tracing` dependency to [v0.1.41][tracing-0.1.41] and the `tracing-serde` dependency to [v0.2.0][tracing-serde-0.2.0]. ### Added - Add `set_span_events` to `fmt::Subscriber` ([#2962]) - **tracing**: Allow `&[u8]` to be recorded as event/span field ([#2954]) ### Changed - Set `log` max level when reloading ([#1270]) - Bump MSRV to 1.63 ([#2793]) - Use const `thread_local`s when possible ([#2838]) - Don't gate `with_ansi()` on the "ansi" feature ([#3020]) - Updated tracing-serde to 0.2.0 ([#3160]) [#1270]: #1270 [#2793]: #2793 [#2838]: #2838 [#2954]: #2954 [#2962]: #2962 [#3020]: #3020 [#3160]: #3160 [tracing-0.1.41]: https://github.com/tokio-rs/tracing/releases/tag/tracing-0.1.41 [tracing-serde-0.2.0]: https://github.com/tokio-rs/tracing/releases/tag/tracing-serde-0.2.0 [docs-0.3.19]: https://docs.rs/tracing-subscriber/0.3.19/tracing_subscriber/ [crate-0.3.19]: https://crates.io/crates/tracing-subscriber/0.3.19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Using reload::Layer with a Filtered layer makes it possible to activate different tracing levels for various modules dynamically. However, it's not currently possible to modify the currently span event configuration since with_span_events can only be set when creating the layer. Due to #1629 it's not possible to completely re-load a layer and so span config is essentially set-once.
Solution
This PR adds a method similar to
set_ansito allow modifying the fmt span configuration in a call toreload::Handle::modifyCloses #2957