Fix some clippy warnings and building with --all-features
#640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like `tonic_web::enable` was removed with the 0.13.x release so this code hasn't actually compiled for a long time. The doc and code examples all use a custom cors layer so whatever heavy lifting the 0.12 method was doing doesn't seem necessary anymore
Features are additive so this should be safe to lint them all together (and avoid the combinatorics of using cargo-hack)
ipetkov
force-pushed
the
push-llzyzxnvqnto
branch
2 times, most recently
from
eecb208 to
f276542
Compare
ipetkov
force-pushed
the
push-llzyzxnvqnto
branch
4 times, most recently
from
be9543b to
a1db8ac
Compare
1. We've already committed our lockfile so there's no need to test the API/subscriber crates individually (if we want to test with the latest available versions we should be running a `cargo update` in CI, so this change remains compatible with the previous behavior) 2. Also enable some non-default feature flags to ensure they are being tested
ipetkov
force-pushed
the
push-llzyzxnvqnto
branch
from
a1db8ac to
3ca49b1
Compare
seanmonstar
approved these changes
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on bumping various dependencies, this is a prerequisite to make sure tests keep passing