Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable cache for Bitbucket #3200

Merged
merged 1 commit into from
Nov 10, 2024

Conversation

DimitarNestorov
Copy link
Contributor

@DimitarNestorov DimitarNestorov commented Nov 5, 2024

Why does this PR exist?

We're not able to pull updates in Figma app for 15 minutes due to Cache-Control header.
image

What does this pull request do?

Disables cache for Bitbucket requests

Testing this change

Open plugin in Figma app and check if pulling is cached

Copy link

changeset-bot bot commented Nov 5, 2024

🦋 Changeset detected

Latest commit: 820a942

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@tokens-studio/figma-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@akshay-gupta7 akshay-gupta7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DimitarNestorov thank you for submitting a PR.
There are failing tests though, can you take a look.
we can review once the tests pass

Copy link
Collaborator

@six7 six7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 Thank you!

(note: The Tests are failing because of how our .env variables for tests are set up, PRs of non-maintainers are not getting those env variables, thus causing them to fail, something for us to fix).

@six7 six7 merged commit fdfc7be into tokens-studio:main Nov 10, 2024
6 of 9 checks passed
@DimitarNestorov
Copy link
Contributor Author

Thanks for merging! @six7 @akshay-gupta7 do you have any ideas when a new version of the plugin will be released?

@akshay-gupta7
Copy link
Contributor

Thanks for merging! @six7 @akshay-gupta7 do you have any ideas when a new version of the plugin will be released?

@DimitarNestorov , we haven't finalized the date yet, should be coming soon within the weeks ahead. Shall keep you posted with any developments on the date we choose

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants