-
-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check variable value before update #3188
Conversation
🦋 Changeset detectedLatest commit: bc70566 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Commit SHA:b9b5ff2bd944c16adfe305146b41690456f32fad Test coverage results 🧪
|
Commit SHA:b9b5ff2bd944c16adfe305146b41690456f32fad |
@keeganedwin were you able to test this? |
@six7 tested the and seems to be working as showed in the video. |
Why does this PR exist?
Closes #3169
Variables weren't checking if they are supposed to update, they just did.
What does this pull request do?
With this change we're making it so that we only update the variable value when the variable value differs from the new value.
Testing this change
Create a few variables, hit Publish in Figma, and then hit export again. In the production version you'd now get another blue dot on the library icon, in this version you don't.
Additional Notes (if any)
CleanShot.2024-10-24.at.09.03.34.mp4