Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metrics update #3141

Merged
merged 5 commits into from
Sep 19, 2024
Merged

metrics update #3141

merged 5 commits into from
Sep 19, 2024

Conversation

six7
Copy link
Collaborator

@six7 six7 commented Sep 17, 2024

Adds a few new metrics to track for mixpanel

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 17, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: cd30dca

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

⤵️ 📦 ✨ The artifact was successfully created! Want to test it? Download it here 👀 🎁

github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 17, 2024
View reviewed changes
packages/tokens-studio-for-figma/src/app/store/remoteTokens.tsx
track('pullTokens failure', { provider: context.provider });
}
} catch (e) {
console.error(e);

Check warning

Code scanning / ESLint

disallow the use of `console` Warning

Unexpected console statement.
packages/tokens-studio-for-figma/src/app/store/remoteTokens.tsx
track('pushTokens failure', { provider: context.provider, isFolder });
}
} catch (e) {
console.error(e);

Check warning

Code scanning / ESLint

disallow the use of `console` Warning

Unexpected console statement.
@github-actions GitHub Actions
Copy link
Contributor

Commit SHA:a8f8c632bd2c034bcd51312edba166a566097907

Test coverage results 🧪

Code coverage diff between base branch:main and head branch: six7/metrics-update
Status File % Stmts % Branch % Funcs % Lines
🟢 total 67.89 (0.04) 58.55 (0.04) 64.64 (0.07) 68.29 (0.04)
🟢 packages/tokens-studio-for-figma/src/app/components/ImportedTokensDialog.tsx 100 (0) 80 (2.59) 100 (0) 100 (0)
🟢 packages/tokens-studio-for-figma/src/app/components/Initiator.tsx 86.48 (1.15) 70.58 (0) 100 (0) 86.11 (1.18)
🟢 packages/tokens-studio-for-figma/src/app/store/remoteTokens.tsx 76.54 (0.99) 60.43 (1.18) 80 (3.08) 76.66 (0.77)
🔴 packages/tokens-studio-for-figma/src/app/store/updateSources.tsx 13.33 (-2.67) 30 (0) 25 (-8.33) 14.28 (-2.38)
🔴 packages/tokens-studio-for-figma/src/app/store/useTokens.tsx 52.52 (-0.22) 34.61 (0) 56.25 (0) 53.36 (-0.24)

@github-actions GitHub Actions
Copy link
Contributor

Commit SHA:a8f8c632bd2c034bcd51312edba166a566097907
Current PR reduces the test coverage percentage by 1 for some tests

@six7 six7 marked this pull request as ready for review September 18, 2024 06:46
macintoshhelper
macintoshhelper approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@macintoshhelper macintoshhelper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Haven't tested the full flow of a prod build and verifying that everything is going to Mixpanel, but trust that it works since there's no change to the Mixpanel track function or config.

@six7 six7 merged commit 834a424 into main Sep 19, 2024
10 of 11 checks passed
@six7 six7 deleted the six7/metrics-update branch September 19, 2024 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macintoshhelper macintoshhelper macintoshhelper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@six7 @macintoshhelper