Fixes remove styles logic #3123
Merged
+71
−56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 98b72fa The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
|
Commit SHA:93b4a88c90abb2a4ef7a4dcd5d5164c58bce3445 Test coverage results 🧪
|
|
Commit SHA:93b4a88c90abb2a4ef7a4dcd5d5164c58bce3445 |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the logic around removing styles and variables without connection to a token. What we did before was we looked at each theme individually, looked at the tokens created in that go, and then removed any styles that were untouched.
This was flawed as it did not take into account other themes in the same session.
Changed this to look at all themes created, combine their created style ids, and only then remove any that were untouched.
To test this,
Remove styles...Before, it did - especially if you were only exporting one of your themes - all other styles were always removed. Note this only applies to Styles, not variables!
CleanShot.2024-09-06.at.09.29.56.mp4
CleanShot.2024-09-06.at.10.04.10.mp4