Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix export sets #3116

Merged
merged 9 commits into from
Sep 6, 2024
Merged

Fix export sets #3116

merged 9 commits into from
Sep 6, 2024

Conversation

akshay-gupta7
Copy link
Contributor

Follow Up PR to fix styling issue where styles are not being applied when sets are being exported as styles(with ignore first part of token names for styles selected)

Description

Fixes the issue where styles are not being applied when sets are being exported as styles (with ignore first part of token names for styles selected)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • None of the above

How to test this

  • Create some themes with enabled sets in the plugin
  • Export selected sets as styles
  • Make sure to check the 'Ignore First Part of token name for Styles' option
  • Choose the sets to export as styles and export to Figma
  • Apply token from a the active theme where the set belongs
  • The corresponding style should now be applied

Screenshots or video (if necessary):

Copy link

changeset-bot bot commented Sep 3, 2024

🦋 Changeset detected

Latest commit: 55b573c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@tokens-studio/figma-plugin Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

deepsource-io bot commented Sep 3, 2024

Here's the code health analysis summary for commits dcd6695..f10cadf. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Shell LogoShell✅ SuccessView Check ↗
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link
Contributor

github-actions bot commented Sep 3, 2024

⤵️ 📦 ✨ The artifact was successfully created! Want to test it? Download it here 👀 🎁

Copy link
Contributor

github-actions bot commented Sep 3, 2024

Commit SHA:35e9f471a3f2d2cc335a1550c64c61fd153deb18

Test coverage results 🧪

Code coverage diff between base branch:main and head branch: fix-export-sets 
Status File % Stmts % Branch % Funcs % Lines
🟢 total 67.93 (0.01) 58.58 (0.05) 64.57 (0.01) 68.35 (0.01)
🟢 packages/tokens-studio-for-figma/src/plugin/TokenValueRetriever.ts 89.47 (0.8) 86.27 (3.35) 100 (0) 93.47 (0.45)

@akshay-gupta7 akshay-gupta7 self-assigned this Sep 4, 2024
@akshay-gupta7 akshay-gupta7 marked this pull request as ready for review September 4, 2024 09:08
@akshay-gupta7 akshay-gupta7 merged commit e1838a3 into main Sep 6, 2024
12 checks passed
@akshay-gupta7 akshay-gupta7 deleted the fix-export-sets branch September 6, 2024 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants