Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent falsy error when pushing to remote (GitLab & ADO) #3105

Merged
merged 3 commits into from
Sep 2, 2024

Conversation

cuserox
Copy link
Contributor

@cuserox cuserox commented Aug 30, 2024

Why does this PR exist?

👀 Original community thread: https://tokens-studio.slack.com/archives/C02DLQXNY6Q/p1724944973329479

When users were pushing to GitLab, an error saying "Push to remote cancelled!" appeared on the modal, although it all works as expected.

What does this pull request do?

For GitLab & ADO, pushing to remote will actually fail, not showing this falsy error.

Testing this change

  • Edit details in GitLab / ADO as a provider
  • Follow the push to remote flow
  • See successful edits in remote OR see error if you cancel the flow

✅ SUCCESS

successfulPush.mp4

❌ ERROR

abandonedPush.mp4

Copy link

changeset-bot bot commented Aug 30, 2024

⚠️ No Changeset found

Latest commit: cd9cfc9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Aug 30, 2024

⤵️ 📦 ✨ The artifact was successfully created! Want to test it? Download it here 👀 🎁

@cuserox cuserox force-pushed the fix/push-to-remote-falsy-error branch from 8514f79 to 2b9c306 Compare August 30, 2024 12:40
Copy link
Contributor

github-actions bot commented Aug 30, 2024

Commit SHA:ddcfe4281f8a1cfa30fb3641759a4a6bfbbe6070

Test coverage results 🧪

Code coverage diff between base branch:main and head branch: fix/push-to-remote-falsy-error 
Status File % Stmts % Branch % Funcs % Lines
🟢 total 67.92 (0) 58.53 (0.01) 64.56 (0) 68.34 (0.01)
🟢 packages/tokens-studio-for-figma/src/app/store/providers/ado/ado.tsx 93.44 (0.7) 80.39 (2.21) 100 (0) 97.39 (0.81)
🟢 packages/tokens-studio-for-figma/src/app/store/providers/gitlab/gitlab.tsx 96.24 (0.69) 83.87 (2.06) 100 (0) 97.61 (0.74)

@cuserox cuserox force-pushed the fix/push-to-remote-falsy-error branch from 561b807 to cd9cfc9 Compare August 30, 2024 16:12
Copy link
Contributor

@akshay-gupta7 akshay-gupta7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@cuserox cuserox merged commit fa987d2 into main Sep 2, 2024
10 checks passed
@cuserox cuserox deleted the fix/push-to-remote-falsy-error branch September 2, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants