-
-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: prevent falsy error when pushing to remote (GitLab & ADO) #3105
Conversation
|
|
8514f79
to
2b9c306
Compare
Commit SHA:ddcfe4281f8a1cfa30fb3641759a4a6bfbbe6070 Test coverage results 🧪
|
561b807
to
cd9cfc9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Why does this PR exist?
👀 Original community thread: https://tokens-studio.slack.com/archives/C02DLQXNY6Q/p1724944973329479
When users were pushing to GitLab, an error saying "Push to remote cancelled!" appeared on the modal, although it all works as expected.
What does this pull request do?
For GitLab & ADO, pushing to remote will actually fail, not showing this falsy error.
Testing this change
✅ SUCCESS
successfulPush.mp4
❌ ERROR
abandonedPush.mp4