Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: non prefix themes styling issue #3103

Merged
merged 21 commits into from
Aug 30, 2024

Conversation

akshay-gupta7
Copy link
Contributor

@akshay-gupta7 akshay-gupta7 commented Aug 28, 2024

Follow Up PR to fix styling issue where styles are not being applied when themes are being exported as non-prefixed styles

Description

Fixes the issue where styles are not being applied when themes are being exported as non-prefixed styles

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • None of the above

How to test this

  • Create some themes with enabled sets in the plugin
  • Export themes as styles
  • Make sure to uncheck the 'Prefix styles with active theme name' option
  • Choose the themes to export as styles and export to Figma
  • Apply token from a particular theme which has been exported
  • The corresponding style should now be applied

Screenshots or video (if necessary):

@akshay-gupta7 akshay-gupta7 self-assigned this Aug 28, 2024
Copy link

changeset-bot bot commented Aug 28, 2024

🦋 Changeset detected

Latest commit: 09d4e04

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@tokens-studio/figma-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Aug 28, 2024

⤵️ 📦 ✨ The artifact was successfully created! Want to test it? Download it here 👀 🎁

Copy link
Contributor

github-actions bot commented Aug 28, 2024

Commit SHA:14549d594c28e2c547d247f3c8e7d68460d6f501

Test coverage results 🧪

Code coverage diff between base branch:main and head branch: fix-non-prefix-themes-styling-issue 
Status File % Stmts % Branch % Funcs % Lines
🔴 total 67.92 (0) 58.52 (-0.03) 64.56 (0) 68.33 (-0.01)
🔴 packages/tokens-studio-for-figma/src/plugin/TokenValueRetriever.ts 88.67 (-0.21) 82.92 (-2.18) 100 (0) 93.02 (-0.16)

Copy link
Contributor

github-actions bot commented Aug 28, 2024

Commit SHA:14549d594c28e2c547d247f3c8e7d68460d6f501
Current PR reduces the test coverage percentage by 1 for some tests

@akshay-gupta7 akshay-gupta7 changed the title Fix non prefix themes styling issue fix: non prefix themes styling issue Aug 28, 2024
@akshay-gupta7 akshay-gupta7 marked this pull request as ready for review August 29, 2024 06:53
@akshay-gupta7 akshay-gupta7 marked this pull request as draft August 29, 2024 07:50
@akshay-gupta7 akshay-gupta7 marked this pull request as ready for review August 30, 2024 09:18
Copy link
Contributor

@cuserox cuserox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with the caveat that it needs some more manual testing. If all good then 👌

@akshay-gupta7 akshay-gupta7 merged commit 9f8c036 into main Aug 30, 2024
9 of 10 checks passed
@akshay-gupta7 akshay-gupta7 deleted the fix-non-prefix-themes-styling-issue branch August 30, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants