Skip to content

Fix generated namespace types in index.d.ts #489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
toji merged 1 commit into from
Jul 14, 2025
Merged

Fix generated namespace types in index.d.ts #489

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions utils/bundle-dts.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ if (typingsLength == typings.length)
// Rename common module to glMatrix
typings = typings.replace(
'declare module "common" {',
"export module glMatrix {"
"export namespace glMatrix {"
);

// Replace imports from other modules with direct references
Expand All @@ -29,7 +29,7 @@ typings = typings.replace(/import\("([^"]+?)(\.js)?"\)/g, "$1");
typings = typings.replace(/ *import.+from.*;/g, "");

// Replace declare module with exports
typings = typings.replace(/declare module "([^"]+?)" {/g, "export module $1 {");
typings = typings.replace(/declare module "([^"]+?)" {/g, "export namespace $1 {");

// Add types
typings = "\n" + sourceTypings.replace(/declare/g, "export") + "\n" + typings;
Expand Down