Fix generated namespace types in index.d.ts #489
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously some namespace types were generated using the legacy `module` keyword from ten years ago. Now we emit the modern TS `namespace` keyword that has been the preferred keyword since TypeScript 1.5 in 2015. Please review the resulting diff for the generated `dist/index.d.ts` file: https://gist.github.com/robpalme/a320dc3f0cb50bcd14962bca46827dae/revisions Note that the outer _Ambient Module Declaration_ intentionally remains untouched because it is not a namespace. These are differentiated by using a quoted string rather than a bare identifier `module "quoted" {` vs `module bare {}` --- Background: This usage of the legacy keyword was found by [a TypeScript real-world test suite](microsoft/TypeScript#61450 (comment)) that checks the compatibility of proposed changes. Using the `module` keyword for namespaces is [proposed for deprecation in TypeScript 6.0](microsoft/TypeScript#54500 (comment)) so it's worth getting ahead of this.
Owner
|
LGTM, thanks! |
Contributor
Author
|
Please could we get a v3.4.4 npm release to make this PR available to consuming projects? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backports #487 (comment) to v3.4.x branch
Previously some namespace types were generated using the legacy
modulekeyword from ten years ago. Now we emit the modern TSnamespacekeyword that has been the preferred keyword since TypeScript 1.5 in 2015.Please review the resulting diff for the generated
dist/index.d.tsfile: https://gist.github.com/robpalme/a320dc3f0cb50bcd14962bca46827dae/revisionsNote that the outer Ambient Module Declaration intentionally remains untouched because it is not a namespace. These are differentiated by using a quoted string rather than a bare identifier
module "quoted" {vs
module bare {}Background: This usage of the legacy keyword was found by a TypeScript real-world test suite that checks the compatibility of proposed changes. Using the
modulekeyword for namespaces is proposed for deprecation in TypeScript 6.0 so it's worth getting ahead of this.