Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): link generation for selected blocks #8087

Merged

Conversation

fundon
Copy link
Contributor

@fundon fundon commented Sep 4, 2024

Closes BS-1321

Screen.Recording.2024-09-04.at.18.44.15.mov

Copy link

graphite-app bot commented Sep 4, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

fundon commented Sep 4, 2024

Copy link

nx-cloud bot commented Sep 4, 2024

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 4.00000% with 24 lines in your changes missing coverage. Please review.

Project coverage is 52.43%. Comparing base (19a7d1e) to head (059030f).
Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
...es/frontend/core/src/hooks/affine/use-share-url.ts 4.00% 24 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #8087      +/-   ##
==========================================
+ Coverage   52.40%   52.43%   +0.02%     
==========================================
  Files        1230     1229       -1     
  Lines       48306    48318      +12     
  Branches     5891     5899       +8     
==========================================
+ Hits        25317    25334      +17     
+ Misses      22614    22609       -5     
  Partials      375      375              
Flag Coverage Δ
server-test 77.31% <ø> (+0.07%) ⬆️
unittest 25.18% <4.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fundon fundon force-pushed the fundon/09_03_add_tracking_code_for_copy_block_to_link branch from 773e7e8 to 7873192 Compare September 4, 2024 08:49
@fundon fundon force-pushed the fundon/09_04_fix_link_generation_for_selected_blocks branch from 584c2fd to c92aa60 Compare September 4, 2024 08:49
@fundon fundon marked this pull request as ready for review September 4, 2024 08:52
@fundon fundon force-pushed the fundon/09_04_fix_link_generation_for_selected_blocks branch from c92aa60 to 74cf4de Compare September 4, 2024 09:44
@fundon fundon force-pushed the fundon/09_03_add_tracking_code_for_copy_block_to_link branch from b46a99f to 389b0e4 Compare September 4, 2024 10:06
@fundon fundon force-pushed the fundon/09_04_fix_link_generation_for_selected_blocks branch 3 times, most recently from 4936e68 to 79aecdb Compare September 4, 2024 12:39
@fundon fundon force-pushed the fundon/09_03_add_tracking_code_for_copy_block_to_link branch from 8bc0e59 to c22da3c Compare September 5, 2024 02:48
@fundon fundon force-pushed the fundon/09_04_fix_link_generation_for_selected_blocks branch from 79aecdb to a62a19b Compare September 5, 2024 02:48
@fundon fundon changed the base branch from fundon/09_03_add_tracking_code_for_copy_block_to_link to graphite-base/8087 September 5, 2024 03:12
@fundon fundon force-pushed the fundon/09_04_fix_link_generation_for_selected_blocks branch from a62a19b to 0a7d2f9 Compare September 5, 2024 03:39
@fundon fundon requested a review from EYHN September 5, 2024 03:39
@fundon fundon force-pushed the fundon/09_04_fix_link_generation_for_selected_blocks branch from 0a7d2f9 to 303ad6e Compare September 5, 2024 03:47
@fundon fundon changed the base branch from graphite-base/8087 to canary September 5, 2024 03:47
Copy link

graphite-app bot commented Sep 5, 2024

Merge activity

@fundon fundon force-pushed the fundon/09_04_fix_link_generation_for_selected_blocks branch from 4db1df9 to 059030f Compare September 5, 2024 07:47
@graphite-app graphite-app bot merged commit 059030f into canary Sep 5, 2024
38 checks passed
@graphite-app graphite-app bot deleted the fundon/09_04_fix_link_generation_for_selected_blocks branch September 5, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants