Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add block and element toolbar widget custom config #7886

Conversation

fundon
Copy link
Contributor

@fundon fundon commented Aug 15, 2024

Upstreams: toeverything/blocksuite#8001 toeverything/blocksuite#7964

  • add block/element toolbar widget config
  • add Copy link to block to more menu on block/element toolbar
Screenshot 2024-08-16 at 16 20 08

Copy link

graphite-app bot commented Aug 15, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

fundon commented Aug 15, 2024

Copy link

nx-cloud bot commented Aug 15, 2024

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 2.38095% with 41 lines in your changes missing coverage. Please review.

Project coverage is 52.38%. Comparing base (ad11007) to head (c3ae219).
Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
...block-suite-editor/specs/custom/widgets/toolbar.ts 0.00% 41 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #7886      +/-   ##
==========================================
- Coverage   52.48%   52.38%   -0.10%     
==========================================
  Files        1215     1218       +3     
  Lines       48208    48302      +94     
  Branches     5855     5880      +25     
==========================================
+ Hits        25300    25304       +4     
- Misses      22536    22626      +90     
  Partials      372      372              
Flag Coverage Δ
server-test 77.58% <ø> (ø)
unittest 25.29% <2.38%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fundon fundon force-pushed the fundon/feat/08_15_add_edgeless_element_toolbar_widget_custom_config branch 12 times, most recently from 7707604 to 036d57c Compare August 19, 2024 06:51
@fundon fundon changed the title feat(core): add edgeless element toolbar widget custom config feat(core): add block and element toolbar widget custom config Aug 20, 2024
@fundon fundon force-pushed the fundon/feat/08_15_add_edgeless_element_toolbar_widget_custom_config branch 2 times, most recently from ea3c0d8 to d93ac23 Compare August 21, 2024 01:03
@fundon fundon force-pushed the fundon/feat/08_15_add_edgeless_element_toolbar_widget_custom_config branch 3 times, most recently from c39e228 to b8bb736 Compare August 27, 2024 11:31
@fundon fundon force-pushed the fundon/feat/08_15_add_edgeless_element_toolbar_widget_custom_config branch from c89edb8 to ed09116 Compare August 28, 2024 12:21
@fundon fundon force-pushed the fundon/feat/08_15_add_edgeless_element_toolbar_widget_custom_config branch from ed09116 to 618e474 Compare August 28, 2024 15:01
@fundon fundon force-pushed the fundon/feat/08_15_add_edgeless_element_toolbar_widget_custom_config branch from 618e474 to 39a9155 Compare August 29, 2024 02:18
@fundon fundon force-pushed the fundon/feat/08_15_add_edgeless_element_toolbar_widget_custom_config branch from 39a9155 to a935e1e Compare August 29, 2024 10:44
@fundon fundon force-pushed the fundon/feat/08_15_add_edgeless_element_toolbar_widget_custom_config branch 3 times, most recently from db9355a to a0c0376 Compare August 30, 2024 06:35
@github-actions github-actions bot added the mod:infra Environment related issues and discussions label Aug 30, 2024
@fundon fundon force-pushed the fundon/feat/08_15_add_edgeless_element_toolbar_widget_custom_config branch 2 times, most recently from bb2a32e to a87fea9 Compare August 30, 2024 07:24
@github-actions github-actions bot added the test Related to test cases label Aug 30, 2024
@fundon fundon force-pushed the fundon/feat/08_15_add_edgeless_element_toolbar_widget_custom_config branch 2 times, most recently from 0ba758b to 96a6f72 Compare August 30, 2024 08:29
@fundon fundon force-pushed the fundon/feat/08_15_add_edgeless_element_toolbar_widget_custom_config branch from 96a6f72 to eb5bdb2 Compare September 3, 2024 00:05
@fundon
Copy link
Contributor Author

fundon commented Sep 3, 2024

Thanks for them comments.
If we want a friendlier API, we should invest some time and design it properly.

Copy link

graphite-app bot commented Sep 3, 2024

Merge activity

Upstreams: toeverything/blocksuite#8001 toeverything/blocksuite#7964

* add block/element toolbar widget config
* add `Copy link to block` to `more menu` on  block/element toolbar

<img width="376" alt="Screenshot 2024-08-16 at 16 20 08" src="https://github.com/user-attachments/assets/49b41de9-39d1-4f55-ac9b-445fe020187a">
@EYHN EYHN force-pushed the fundon/feat/08_15_add_edgeless_element_toolbar_widget_custom_config branch from eb5bdb2 to c3ae219 Compare September 3, 2024 03:52
@graphite-app graphite-app bot merged commit c3ae219 into canary Sep 3, 2024
38 checks passed
@graphite-app graphite-app bot deleted the fundon/feat/08_15_add_edgeless_element_toolbar_widget_custom_config branch September 3, 2024 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core mod:infra Environment related issues and discussions test Related to test cases
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants